-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug in AddInputOutputOpsPass: check existence of key in HashMap(inferface_lbi2scope_sym_id) #5653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nferface_lbi2scope_sym_id)
zzk0
added a commit
to zzk0/oneflow
that referenced
this pull request
Aug 3, 2021
…ce of key in HashMap(inferface_lbi2scope_sym_id)
leaves-zwx
reviewed
Aug 6, 2021
leaves-zwx
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 复现
python/oneflow/serving/saved_model_builder.py
将模型保存下来,并且增加一个自定义 Signature。python/oneflow/serving/inference_session.py
读取模型,在调用CurJobBuildAndInferCtx_Complete
的时候报错。问题定位
单步调试,直到发现是在 AddInputOutputOpsPass 中出了问题。仔细阅读了代码之后,发现:如果一个 Input 并不参与计算但它又存在,也就是说从 output 反向遍历不到的话,这个 Input 是不会加入到一个 HashMap 中的。可是,后面的代码会根据 signature 去 HashMap 找 Input 对应的 key。
代码错误发生在
附:
下面是报错信息和保存的模型。
模型,删除了中间的东西,下面的 Input_15 是没用到的