-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[part8]Remove singleclient outdated api #5750
Merged
oneflow-ci-bot
merged 10 commits into
master
from
remove_singleclient_outdated_api_part8
Aug 8, 2021
Merged
[part8]Remove singleclient outdated api #5750
oneflow-ci-bot
merged 10 commits into
master
from
remove_singleclient_outdated_api_part8
Aug 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luqiang-guo
changed the title
Delete part of the interface
[part8]Remove singleclient outdated api
Aug 5, 2021
luqiang-guo
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
August 6, 2021 10:34
chengtbf
approved these changes
Aug 6, 2021
doombeaker
reviewed
Aug 6, 2021
@@ -152,12 +149,6 @@ def Sync(): | |||
import oneflow.nn.modules.tan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其实这种包(tan.py 文件,而不是 tan.py 文件中的 tan 函数),也是多余导出的。
可以顺遍删除了(不用在这个PR中)。
注意这里的大部分是多余的,但不是所有是多余的,比如 oneflow.nn.image 就真是一个 sub pakcage。
但是像 tan、sinh 等这些和 op 重名的 pakcage,都会被后面的代码导入的op覆盖,在这里是多余的。
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
August 8, 2021 05:34
Speed stats:
|
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
August 8, 2021 09:08
Speed stats:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
删除multiclient 下single client的接口
总删除列表
此pr完成了一部分接口清理。