Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[part8]Remove singleclient outdated api #5750

Merged
merged 10 commits into from
Aug 8, 2021

Conversation

luqiang-guo
Copy link
Contributor

@luqiang-guo luqiang-guo commented Aug 5, 2021

删除multiclient 下single client的接口

总删除列表

此pr完成了一部分接口清理。

  • JobConfigProto
  • ConfigProto
  • Session
  • cast_to_current_logical_view
  • truncated_normal
  • name_scope
  • get_all_variables

@luqiang-guo luqiang-guo added purge purge obsolete code python labels Aug 5, 2021
@luqiang-guo luqiang-guo requested a review from doombeaker August 5, 2021 11:00
@luqiang-guo luqiang-guo changed the title Delete part of the interface [part8]Remove singleclient outdated api Aug 5, 2021
@luqiang-guo luqiang-guo requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 6, 2021 10:34
@@ -152,12 +149,6 @@ def Sync():
import oneflow.nn.modules.tan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其实这种包(tan.py 文件,而不是 tan.py 文件中的 tan 函数),也是多余导出的。
可以顺遍删除了(不用在这个PR中)。

注意这里的大部分是多余的,但不是所有是多余的,比如 oneflow.nn.image 就真是一个 sub pakcage。
但是像 tan、sinh 等这些和 op 重名的 pakcage,都会被后面的代码导入的op覆盖,在这里是多余的。

@chengtbf chengtbf removed the request for review from oneflow-ci-bot August 6, 2021 16:33
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 8, 2021 05:34
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2021

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 140.4ms (= 7020.8ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 128.2ms (= 6410.0ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.10 (= 140.4ms / 128.2ms)

PyTorch resnet50 time: 85.9ms (= 4297.0ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 74.3ms (= 3716.7ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.16 (= 85.9ms / 74.3ms)

PyTorch resnet50 time: 57.1ms (= 2854.1ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 47.3ms (= 2366.8ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.21 (= 57.1ms / 47.3ms)

PyTorch resnet50 time: 48.5ms (= 2426.9ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 44.5ms (= 2223.3ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.09 (= 48.5ms / 44.5ms)

PyTorch resnet50 time: 42.1ms (= 2105.7ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 45.5ms (= 2273.6ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 0.93 (= 42.1ms / 45.5ms)

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 8, 2021 07:32
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 8, 2021 09:08
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2021

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 137.9ms (= 6893.7ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 126.2ms (= 6307.6ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.09 (= 137.9ms / 126.2ms)

PyTorch resnet50 time: 81.0ms (= 4047.6ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 72.8ms (= 3639.9ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.11 (= 81.0ms / 72.8ms)

PyTorch resnet50 time: 56.9ms (= 2843.4ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 47.9ms (= 2393.6ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.19 (= 56.9ms / 47.9ms)

PyTorch resnet50 time: 47.6ms (= 2379.3ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 42.3ms (= 2112.8ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.13 (= 47.6ms / 42.3ms)

PyTorch resnet50 time: 39.9ms (= 1996.5ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 50.2ms (= 2508.6ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 0.80 (= 39.9ms / 50.2ms)

@oneflow-ci-bot oneflow-ci-bot merged commit 6cb73a1 into master Aug 8, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the remove_singleclient_outdated_api_part8 branch August 8, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge purge purge obsolete code python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants