-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[part9]Remove singleclient outdated api #5752
[part9]Remove singleclient outdated api #5752
Conversation
…ub.com/Oneflow-Inc/oneflow into remove_singleclient_outdated_api_part9 Conflicts: python/oneflow/__init__.py
python/oneflow/framework/env_util.py
Outdated
""" | ||
return enable_if.unique([get_current_resource])() | ||
|
||
|
||
@enable_if.condition(hob.in_normal_mode & hob.env_initialized) | ||
def get_current_resource(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些是不是也一并删掉?
python/oneflow/framework/env_util.py
Outdated
@enable_if.condition(hob.in_normal_mode & hob.env_initialized) | ||
def get_current_machine_id() -> int: | ||
return oneflow._oneflow_internal.CurrentMachineId() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
一并删除
api_func = enable_if.unique( | ||
[GetCurrentLazyGlobalFunctionDesc, GetCurrentEagerGlobalFunctionDesc] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
上面对应的这两个函数也一并删除
|
||
|
||
def Init() -> None: | ||
sync_default_session_if_normal() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个文件的改动请 @daquexian 大老师看一下吧~
@@ -587,31 +566,3 @@ def GenerateValueAndAssign(var_blob, start_nd_idx, stop_nd_idx): | |||
pass | |||
if sync_between_multi_machine: | |||
oneflow._oneflow_internal.eager.single_client.Sync() | |||
|
|||
|
|||
def Init() -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
对这个函数的调用也一起删掉吧,应该在 session_util.py
Speed stats:
|
删除multiclient 下single client的接口
总删除列表
此pr完成了一部分接口清理。