Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix weight decay in RMSprop #5755

Merged
merged 8 commits into from Aug 9, 2021
Merged

fix weight decay in RMSprop #5755

merged 8 commits into from Aug 9, 2021

Conversation

L1aoXingyu
Copy link
Contributor

fix unittest rmsprop numpy implementation without weight decay
passing weight decay as l2 in rmsprop optimizer

@L1aoXingyu L1aoXingyu requested a review from wyg1997 August 5, 2021 13:44
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 6, 2021 08:31
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 6, 2021 10:43
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 6, 2021 14:05
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2021

CI failed, removing label automerge

@github-actions github-actions bot removed the automerge label Aug 6, 2021
@oneflow-ci-bot oneflow-ci-bot removed their request for review August 6, 2021 17:49
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2021

CI failed, removing label automerge

@github-actions github-actions bot removed the automerge label Aug 9, 2021
@oneflow-ci-bot oneflow-ci-bot removed their request for review August 9, 2021 03:10
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2021

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 141.2ms (= 7061.8ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 127.7ms (= 6386.8ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.11 (= 141.2ms / 127.7ms)

PyTorch resnet50 time: 83.3ms (= 4164.7ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 74.2ms (= 3708.0ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.12 (= 83.3ms / 74.2ms)

PyTorch resnet50 time: 56.5ms (= 2824.9ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 47.6ms (= 2381.2ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.19 (= 56.5ms / 47.6ms)

PyTorch resnet50 time: 48.5ms (= 2423.8ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 40.5ms (= 2025.4ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.20 (= 48.5ms / 40.5ms)

PyTorch resnet50 time: 39.8ms (= 1989.3ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 41.5ms (= 2072.8ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 0.96 (= 39.8ms / 41.5ms)

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 9, 2021 03:59
@L1aoXingyu L1aoXingyu merged commit bf618ba into master Aug 9, 2021
@L1aoXingyu L1aoXingyu deleted the fix_rmsprop branch August 9, 2021 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants