-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[part10]Remove singleclient outdated api #5756
[part10]Remove singleclient outdated api #5756
Conversation
python/oneflow/framework/ops.py
Outdated
func = enable_if.unique([pack]) | ||
return func(input, pack_num, name=name) | ||
|
||
|
||
@enable_if.condition(hob.in_global_mode & ~hob.eager_execution_enabled) | ||
def pack(input, pack_num, name=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个也没用了吧
max_acc_num: int, | ||
name: Optional[str] = None, | ||
) -> oneflow._oneflow_internal.BlobDesc: | ||
func = enable_if.unique([acc]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这种api_acc包一层的接口,都可以把对应的函数删除
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
后面几个pr都是同样的问题,一起处理一下吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的我一起处理
class DeprecatedFixedTensorDef(FixedTensorDef): | ||
def __init__(self, *args, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FixedTensorDef和下面的MirroredTensorDef可以直接删除
grad_parallel_distribution: Sequence[str] = None, | ||
name: Optional[str] = None, | ||
) -> oneflow._oneflow_internal.BlobDesc: | ||
func = enable_if.unique([hierarchical_parallel_cast]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已经清理干净
python/oneflow/framework/ops.py
Outdated
.RemoteBlobList()[0] | ||
) | ||
|
||
|
||
def api_parallel_cast( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没清理干净。。。这些都没删
python/oneflow/framework/ops.py
Outdated
.RemoteBlobList()[0] | ||
) | ||
|
||
|
||
def api_unpack( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个也没删?
Speed stats:
|
删除multiclient 下single client的接口
总删除列表
此pr完成了一部分接口清理。