Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev RMSprop graph conf #5768

Merged
merged 71 commits into from
Aug 12, 2021
Merged

Dev RMSprop graph conf #5768

merged 71 commits into from
Aug 12, 2021

Conversation

L1aoXingyu
Copy link
Contributor

  • Add RMSprop conf for nn-Graph
  • Add unittest for RMSprop conf

@CLAassistant
Copy link

CLAassistant commented Aug 6, 2021

CLA assistant check
All committers have signed the CLA.

@L1aoXingyu
Copy link
Contributor Author

L1aoXingyu commented Aug 6, 2021

两点疑问:

  • 通过看注释发现 RMSprop 当前并不支持 momentum > 0
  • RMSprop for nn-Graph 是否不支持 scale != 1.0

@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 11, 2021 16:29
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 11, 2021 18:39
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 11, 2021 20:13
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 11, 2021 21:58
@github-actions
Copy link
Contributor

CI failed, removing label automerge

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 11, 2021 23:42
@L1aoXingyu L1aoXingyu requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 12, 2021 02:13
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 12, 2021 03:08
@github-actions
Copy link
Contributor

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 140.6ms (= 7029.7ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 127.8ms (= 6389.7ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.10 (= 140.6ms / 127.8ms)

PyTorch resnet50 time: 83.6ms (= 4182.4ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 74.1ms (= 3706.8ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.13 (= 83.6ms / 74.1ms)

PyTorch resnet50 time: 58.7ms (= 2933.4ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 48.8ms (= 2438.9ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.20 (= 58.7ms / 48.8ms)

PyTorch resnet50 time: 47.8ms (= 2388.7ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 40.0ms (= 2000.9ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.19 (= 47.8ms / 40.0ms)

PyTorch resnet50 time: 42.0ms (= 2098.2ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 39.4ms (= 1971.6ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 1.06 (= 42.0ms / 39.4ms)

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 12, 2021 05:31
@oneflow-ci-bot oneflow-ci-bot merged commit 131d3bb into master Aug 12, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the dev_-rmsprop_graph_conf branch August 12, 2021 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants