Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename variables named *parallel_distribution* to *nd_sbp* (1) #5815

Merged
merged 28 commits into from
Aug 12, 2021

Conversation

terryzhao127
Copy link

Rename parallel_distribution to nd_sbp

@terryzhao127 terryzhao127 requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 10, 2021 01:12
@github-actions
Copy link
Contributor

CI failed, removing label automerge

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 10, 2021 03:21
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 10, 2021 03:55
@oneflow-ci-bot oneflow-ci-bot removed their request for review August 10, 2021 06:32
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 11, 2021 04:34
@github-actions
Copy link
Contributor

CI failed, removing label automerge

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 11, 2021 06:25
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 11, 2021 16:30
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 11, 2021 18:40
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 11, 2021 20:14
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 11, 2021 21:59
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 12, 2021 00:25
@github-actions
Copy link
Contributor

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 140.7ms (= 7037.1ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 128.1ms (= 6407.0ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.10 (= 140.7ms / 128.1ms)

PyTorch resnet50 time: 84.2ms (= 4212.1ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 74.3ms (= 3714.3ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.13 (= 84.2ms / 74.3ms)

PyTorch resnet50 time: 55.0ms (= 2748.1ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 47.7ms (= 2383.5ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.15 (= 55.0ms / 47.7ms)

PyTorch resnet50 time: 48.3ms (= 2413.1ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 44.6ms (= 2227.5ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.08 (= 48.3ms / 44.6ms)

PyTorch resnet50 time: 44.0ms (= 2200.7ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 40.4ms (= 2021.1ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 1.09 (= 44.0ms / 40.4ms)

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 12, 2021 03:05
@oneflow-ci-bot oneflow-ci-bot merged commit 1ba1397 into master Aug 12, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the rename_parallel_distribution_variable branch August 12, 2021 03:07
@terryzhao127 terryzhao127 changed the title Rename variables named *parallel_distribution* to *nd_sbp* Rename variables named *parallel_distribution* to *nd_sbp* (1) Aug 12, 2021
@terryzhao127 terryzhao127 restored the rename_parallel_distribution_variable branch August 12, 2021 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants