Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Single-Client API in oneflow default python #5827

Merged
merged 37 commits into from Aug 13, 2021

Conversation

chengtbf
Copy link
Contributor

@chengtbf chengtbf commented Aug 10, 2021

移除 oneflow 主命名空间 (除去 oneflow.compatible.single_client 之外)内的 Single-Client API。

  • refine oneflow.__init__.py
  • 移除目录 python/oneflow/advanced/*
  • 移除目录 python/oneflow/benchmarks/*
  • 移除命名空间 oneflow.checkpoint
  • 移除命名空间 oneflow.config 与 目录 python/oneflow/config/*
  • 移除目录 python/oneflow/deprecated/*
  • 移除命名空间 oneflow.distribute
  • 移除命名空间 oneflow.eager (除 oneflow.eager.interpreter_callback 以外的其他内容)
  • oneflow.env 只暴露一个 api: all_device_placement
  • 移除命名空间 oneflow.experimental (除 oneflow.data.load_mnist)
  • 移除 oneflow.framework 下的 blob_trait,checkpoint,compile_context,complier,distribute_context,input_blob_def,interpret_util,local_blob, module,op_util, ops,placement_context,placement_util,pull_util,push_util,remote_blob,scope_symbol,session_util,typing,typing_util,variable_getter_composite,watcher
  • 移除命名空间 oneflow.layers
  • 移除命名空间 oneflow.math
  • 移除目录 python/oneflow/ops/* 中的主要文件(剩余文件后续会迁移到 nn 目录下)
  • 移除目录 python/oneflow/optimizer/*
  • 移除命名空间 oneflow.random
  • 移除命名空间 oneflow.regularizers
  • 移除命名空间 oneflow.scope
  • 移除命名空间 oneflow.train
  • 移除命名空间 oneflow.typing
  • 移除命名空间 oneflow.tmp
  • 移除命名空间 oneflow.util
  • 禁用 oneflow.framework.model
  • 禁用 oneflow.saved_model
  • 移除 oneflow.framework.check_point_v2 下对 老版本 Eager 的部分
  • refine 了 oneflow.framework.unittest,register_class_method_util 的逻辑

@chengtbf chengtbf changed the title Dev cc rm single client api Remove Single-Client API in oneflow default python Aug 10, 2021
@chengtbf chengtbf requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 10, 2021 12:29
@github-actions
Copy link
Contributor

CI failed, removing label automerge

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 10, 2021 13:55
@chengtbf chengtbf removed the request for review from oneflow-ci-bot August 11, 2021 01:40
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 12, 2021 19:55
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 12, 2021 21:48
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 12, 2021 23:01
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 13, 2021 00:13
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 13, 2021 01:52
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 13, 2021 02:50
@github-actions
Copy link
Contributor

CI failed, removing label automerge

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 13, 2021 04:06
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 13, 2021 04:49
@github-actions
Copy link
Contributor

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 139.2ms (= 6962.4ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 128.2ms (= 6408.1ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.09 (= 139.2ms / 128.2ms)

PyTorch resnet50 time: 83.8ms (= 4187.9ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 74.6ms (= 3727.6ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.12 (= 83.8ms / 74.6ms)

PyTorch resnet50 time: 61.1ms (= 3057.2ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 47.3ms (= 2366.3ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.29 (= 61.1ms / 47.3ms)

PyTorch resnet50 time: 48.4ms (= 2419.7ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 40.3ms (= 2013.0ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.20 (= 48.4ms / 40.3ms)

PyTorch resnet50 time: 44.2ms (= 2211.6ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 33.6ms (= 1680.9ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 1.32 (= 44.2ms / 33.6ms)

@oneflow-ci-bot oneflow-ci-bot merged commit b6544d6 into master Aug 13, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the dev_cc_rm_single_client_api branch August 13, 2021 06:27
@chengtbf chengtbf linked an issue Sep 6, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge purge purge obsolete code python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

删除multiclient 下旧的single client接口
5 participants