Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ddp grad size #5834

Merged
merged 15 commits into from
Aug 12, 2021
Merged

Fix ddp grad size #5834

merged 15 commits into from
Aug 12, 2021

Conversation

daquexian
Copy link
Contributor

修复 ddp 梯度尺寸不对的问题,改进单测

Signed-off-by: daquexian <daquexian566@gmail.com>
Signed-off-by: daquexian <daquexian566@gmail.com>
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 11, 2021 10:01
@oneflow-ci-bot oneflow-ci-bot removed their request for review August 11, 2021 11:38
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 11, 2021 16:24
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 11, 2021 18:40
@oneflow-ci-bot oneflow-ci-bot removed their request for review August 11, 2021 20:14
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 11, 2021 21:59
@oneflow-ci-bot oneflow-ci-bot removed their request for review August 12, 2021 00:26
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 12, 2021 00:26
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 12, 2021 03:10
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 12, 2021 05:33
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 12, 2021 08:30
@github-actions
Copy link
Contributor

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 154.6ms (= 7728.7ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 133.4ms (= 6667.7ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.16 (= 154.6ms / 133.4ms)

PyTorch resnet50 time: 98.6ms (= 4930.2ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 72.8ms (= 3642.0ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.35 (= 98.6ms / 72.8ms)

PyTorch resnet50 time: 73.6ms (= 3680.7ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 79.2ms (= 3961.1ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 0.93 (= 73.6ms / 79.2ms)

PyTorch resnet50 time: 103.0ms (= 5149.7ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 52.8ms (= 2638.8ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.95 (= 103.0ms / 52.8ms)

PyTorch resnet50 time: 87.1ms (= 4353.0ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 66.1ms (= 3303.6ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 1.32 (= 87.1ms / 66.1ms)

@oneflow-ci-bot oneflow-ci-bot merged commit 96e2e32 into master Aug 12, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the fix_ddp_grad_size branch August 12, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants