einsum functor #5985
Closed
einsum functor #5985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| out_shape[i] = permuted_operands[dim_last_op[i]]->dim(i); | ||
| } | ||
| return std::shared_ptr<Tensor>(); | ||
| // TODO: need function supporting construct zeros tensor with shape |
There was a problem hiding this comment.
用 ConstantFunctor 可以吗
hjchen2
reviewed
Aug 23, 2021
| @@ -1049,6 +1049,10 @@ | |||
| SbpList sbp_tuple, DataType dtype=None, Generator generator=None)" | |||
| bind_python: True | |||
|
|
|||
| - name: "einsum" | |||
| signature: "Tensor EinSum(String einsum_formula, TensorTuple inputs)" | |||
There was a problem hiding this comment.
注意一下新版functional接口的规范，https://github.com/Oneflow-Inc/oneflow/wiki/Functional-Interface，改成下面的定义，
signature: "Tensor (String einsum_formula, TensorTuple inputs) => EinSum"
hjchen2
reviewed
Aug 23, 2021
|
|
||
| // Multiply tensors and sum out dimensions in sum_dims | ||
| if (sum_dims.empty()) { | ||
| result = JUST(Multiply(result, operand)); |
|
Is there any progress? |
|
我们这个einsum 的完成度怎么样，还差多少工作量，感觉爱因斯坦求和用处还挺多的，alphafold 的实现就用了 |
|
@Ldpe2G hi, I have already noticed your excellent pr yesterday. Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables users to construct complex tensor computations given the text description in Einstein summation format.
TODO: some steps in the current implementation need new operators' support, e.g. diagonal operation for any two dimensions.