Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/724 create and delete conceptscheme #725

Conversation

mielvds
Copy link
Contributor

@mielvds mielvds commented Sep 5, 2022

In light of getting familiar with the project and testing how easy it would be to contribute, a potential and partial implementation of #724. I will need some guidance on the database and UI aspects though; haven't completely figured out how the Dojo and ORM stuff works.

@mielvds mielvds mentioned this pull request Sep 5, 2022
@mielvds mielvds force-pushed the feature/724-create-and-delete-conceptscheme branch from 5c774dd to 0c4a437 Compare September 6, 2022 13:41
@koenedaele
Copy link
Member

Thank you. This will end up being a big PR, so I'll have to talk to my colleagues on how structure this for development.

Sorry about the Dojo stuff, that's a really old framework. One day we'd like to completely rewrite the UI as well, but now is probably not the best time :-)

@mielvds
Copy link
Contributor Author

mielvds commented Sep 7, 2022

Thank you. This will end up being a big PR, so I'll have to talk to my colleagues on how structure this for development.

I say thank you for building such an easy to work with application! Hopefully some of this is useful and please don't perceive this as pushy :)

Just some trailing thought with this PR:

  • the dialog for creating the scheme is very basic just to get something working; don't mind the rough input fields. I imagined the label dialog you already have instead, but it was too much work to figure out :) The whole dialog and user flow needs some decent thinking in any case.
  • to delete a scheme I was thinking of adding a red button in the side panel below.

Sorry about the Dojo stuff, that's a really old framework.

It's not that bad to figure out actually, reminds me of react :D They are all the same.

One day we'd like to completely rewrite the UI as well, but now is probably not the best time :-)

I cannot agree more :)

@koenedaele
Copy link
Member

Closing this one as we have split this in several tickets, see #744, #745 and #774

@koenedaele koenedaele closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants