Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make wallet path optional #252

Merged
merged 2 commits into from
Jan 16, 2023
Merged

fix: make wallet path optional #252

merged 2 commits into from
Jan 16, 2023

Conversation

zixiang2018
Copy link
Contributor

Summary

To revert --encrypted-wallet-path arg back to optional so that users can use --key or set their private key in their environment variable to be used

Changes

  • Removed demandOption: true from withWalletOption() option

@zixiang2018 zixiang2018 merged commit 5027020 into master Jan 16, 2023
@john-dot-oa
Copy link

🎉 This PR is included in version 1.57.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

osslgtm added a commit that referenced this pull request Aug 24, 2023
@osslgtm
Squashed commit of the following:
29ad9cc 
commit d93c522
Merge: 00c5ee4 eb241ce
Author: osslgtm <68947167+osslgtm@users.noreply.github.com>
Date:   Wed Aug 23 18:04:31 2023 +0800

    Merge branch 'master' into EIP-1559

commit eb241ce
Author: Anil Chinchawale <anil24593@gmail.com>
Date:   Tue Aug 1 12:44:35 2023 +0530

    fix: add XDC Apothem network in config create (#280)

commit 6984d96
Author: PH <68947167+osslgtm@users.noreply.github.com>
Date:   Wed Jul 26 19:21:00 2023 +0800

    fix: sepolia default infura provider (#277)

commit 61fdc8e
Author: PH <68947167+osslgtm@users.noreply.github.com>
Date:   Wed Jul 26 17:54:21 2023 +0800

    fix: upgrade snyk (#279)

commit d1c509d
Author: PH <68947167+osslgtm@users.noreply.github.com>
Date:   Wed Jul 26 16:15:23 2023 +0800

    feat: upgrade token registry (#276)

commit 26cc5d5
Author: Anil Chinchawale <anil24593@gmail.com>
Date:   Mon Jul 24 15:47:49 2023 +0530

    chore: add XDC Network (#270)

    * feat: add XDC Network

    Merging XDC network as pushed by our partner for TradeTrust

commit 8f04616
Author: PH <68947167+osslgtm@users.noreply.github.com>
Date:   Mon Jul 24 16:07:16 2023 +0800

    feat: blockchain without deployer (#271)

    * feat: bc without deployer

commit 8caeaca
Author: PH <68947167+osslgtm@users.noreply.github.com>
Date:   Mon Jul 24 15:25:02 2023 +0800

    fix: cover letter config (#275)

commit 732ae03
Author: isaackps <isaac.kps@gmail.com>
Date:   Wed Jul 5 18:17:46 2023 +0800

    fix: update goerli deprecation and change to sepolia (#272)

    * fix: update goerli deprecation and change to sepolia

    * fix: add missing return type

    * fix: update enum name to TestNetwork

    * fix: move convertNetworkToNetworkCmdName

commit 1763111
Author: chershentan <tan_cher_shen@tech.gov.sg>
Date:   Thu May 18 13:44:45 2023 +0800

    feat: add aws session-token option to withAwsKmsSignerOption (#261)

    * feat: add aws session-token option to withAwsKmsSignerOption

    * Update src/implementations/utils/wallet.ts

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

    ---------

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

commit d0c7954
Author: PH <68947167+puayhiang@users.noreply.github.com>
Date:   Wed Apr 26 14:33:51 2023 +0800

    feat: oa-cli updates check (#244)

    * feat: update check mechanism

commit 100362e
Author: superical <superical@users.noreply.github.com>
Date:   Thu Apr 20 14:40:31 2023 +0800

    fix: npm release (#268)

commit 0161410
Author: superical <superical@users.noreply.github.com>
Date:   Thu Apr 20 14:02:46 2023 +0800

    fix: release issue again (#267)

commit 143e566
Author: superical <superical@users.noreply.github.com>
Date:   Thu Apr 20 13:27:57 2023 +0800

    fix: release issue (#266)

commit f711945
Author: superical <superical@users.noreply.github.com>
Date:   Thu Apr 20 13:05:50 2023 +0800

    fix: issue with pkg in ci (#265)

commit eb1874f
Author: PH <68947167+puayhiang@users.noreply.github.com>
Date:   Tue Apr 18 13:48:41 2023 +0800

    feat: title escrow factory deployment (#264)

    * feat: title escrow factory

commit 4c00780
Author: PH <68947167+puayhiang@users.noreply.github.com>
Date:   Thu Apr 13 01:03:52 2023 +0800

    feat: token-registry standalone deploy (#260)

    * feat: standalone mode

commit 5e14033
Author: superical <superical@users.noreply.github.com>
Date:   Fri Mar 24 19:19:05 2023 +0800

    ci: migrate ci to github actions (#258)

    * ci: deprecate circleci

    * ci: migrate to github actions

commit 2504499
Author: Puay Hiang <68947167+puayhiang@users.noreply.github.com>
Date:   Wed Mar 15 15:02:13 2023 +0800

    feat(token-registry): Token Registry V4

    BREAKING CHANGE: Token Registry V4

commit b195ad7
Author: Puay Hiang <68947167+puayhiang@users.noreply.github.com>
Date:   Wed Mar 15 14:37:10 2023 +0800

    feat!: Token Registry V4 (#228)

    * feat(token-registry)!: token registry v4

commit 49d6838
Author: isaackps <isaac.kps@gmail.com>
Date:   Tue Jan 31 10:14:08 2023 +0800

    fix: create config encrypted wallet path required (#253)

    * fix: create config encrypted wallet path required

    * fix: remove withWalletOption function

commit 5027020
Author: Tng Zi Xiang <54768054+zixiang2018@users.noreply.github.com>
Date:   Mon Jan 16 14:27:06 2023 +0800

    fix: make wallet path optional (#252)

commit 6b1c6b9
Author: Sim Boon Long <simboonlong@gmail.com>
Date:   Mon Jan 16 12:19:48 2023 +0800

    feat: config other networks (#251)

    * feat: config other networks

    * chore: gt way

    * chore: comment

commit 0533caf
Author: Sim Boon Long <simboonlong@gmail.com>
Date:   Tue Jan 3 13:56:58 2023 +0800

    fix: update form (#247)

commit bc9c257
Author: isaackps <isaac.kps@gmail.com>
Date:   Wed Dec 7 11:02:32 2022 +0800

    feat: update create config command for different networks (#241)

    * feat: update create config command for different networks

    * fix: change passing of password to passing of wallet

    * fix: test cases

    * fix: update according to review

    * fix: withWalletOptions description

    * fix: add note for passedOnWallet

    * fix: comment

commit 4145fda
Author: superical <superical@users.noreply.github.com>
Date:   Thu Nov 24 13:32:39 2022 +0800

    feat: document store owner option (#238)

    * feat: owner option for document store

    * docs: update readme with doc store owner

commit 949351b
Author: superical <superical@users.noreply.github.com>
Date:   Thu Nov 24 13:29:14 2022 +0800

    fix: bump doc store (#237)

    * fix: bump document store

    * test: update param pos

commit 6c35d58
Author: superical <superical@users.noreply.github.com>
Date:   Thu Oct 27 17:53:47 2022 +0800

    fix: add sepolia and mumbai escrow creator (#232)

commit d04dbd3
Author: isaackps <isaac.kps@gmail.com>
Date:   Thu Oct 27 14:33:28 2022 +0800

    feat: deprecate ropsten and rinkeby (#230)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HJunyuan HJunyuan HJunyuan approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zixiang2018 @john-dot-oa @HJunyuan