-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clip: Document edge cases #472
Comments
What have backends impemented? @soxofaan @guss84 @clausmichele @LukeWeidenwalker |
In the xarray/dask implementation, if max < min, no error is raised. The base function is provided by numpy, and they explicitly mention this in the docs: Anyway, we can agree to raise a predefined error if this happens. |
I don't think we have a check either. |
PR: #477 |
Process ID: clip
Describe the issue:
During the test suite creation, I identified that the clip process doesn't mention what happens if min > max for example.
Proposed solution:
We should check the tests and document what's missing, e.g. throw an error if min > max? Check what similar processes do, e.g. between.
Additional context:
Tests in #468
The text was updated successfully, but these errors were encountered: