Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clip: Throw an exception if min > max #472 #477

Merged
merged 2 commits into from
Oct 27, 2023
Merged

clip: Throw an exception if min > max #472 #477

merged 2 commits into from
Oct 27, 2023

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Oct 25, 2023

Had to remove the process_graph, which would not throw the error.

Fixes #472

@m-mohr m-mohr added this to the 2.0.0 milestone Oct 25, 2023
@m-mohr m-mohr mentioned this pull request Oct 25, 2023
Closed
@m-mohr m-mohr linked an issue Oct 25, 2023 that may be closed by this pull request
clip: Document edge cases #472
Closed
@m-mohr m-mohr merged commit 4fd92b2 into draft Oct 27, 2023
2 checks passed
@m-mohr m-mohr deleted the clip branch October 27, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soxofaan soxofaan soxofaan approved these changes

@clausmichele clausmichele clausmichele approved these changes

@LukeWeidenwalker LukeWeidenwalker Awaiting requested review from LukeWeidenwalker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

clip: Document edge cases
3 participants
@m-mohr @soxofaan @clausmichele