fix(XRPLib): update pin names to match latest MicroPython machine config #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, thanks for helping out! Please see my post here: https://xrp.discourse.group/t/micropython-error-during-installation-verification/652/8?u=sparkfro TLDR; some XRP Controller boards (including yours) got shipped with old firmware before we had finalized the pin names. The existing pin names are correct, you'll just need to update your firmware. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read about the issue I ran into here: https://xrp.discourse.group/t/micropython-error-during-installation-verification/652
This PR resolves the above issue by updating the pin names to match what is seen on the
Pin.boardinterface in the MicroPython REPL. I'm not sure when this changed or if this is the correct place to make this change, so feel free to close this if there is a better way to fix the issue.