[tools] convert project metadata to PEP 621 pyproject.toml (#112) #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
flavienSindou
approved these changes
Jun 10, 2025
pyproject.toml
Outdated
Comment on lines
67
to
78
| [tool.setuptools] | ||
| packages = [ | ||
| "pyobas", | ||
| "pyobas.apis", | ||
| "pyobas.apis.inject_expectation", | ||
| "pyobas.apis.inject_expectation.model", | ||
| "pyobas.backends", | ||
| "pyobas.configuration", | ||
| "pyobas.contracts", | ||
| "pyobas.daemons", | ||
| "pyobas.signatures" | ||
| ] |
There was a problem hiding this comment.
TIP :
Since the repo appears to be well structured, I believe you can use setuptools automatic package discovery instead of specifying an explicit list:
[tool.setuptools.packages.find]
https://setuptools.pypa.io/en/latest/userguide/package_discovery.html#custom-discovery
There was a problem hiding this comment.
Cheers for this, good thinking.
Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...