Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diff results of operation ID (metadata) #191

Merged
merged 2 commits into from
Dec 6, 2020
Merged

Add diff results of operation ID (metadata) #191

merged 2 commits into from
Dec 6, 2020

Conversation

hiddewie
Copy link
Contributor

@hiddewie hiddewie commented Oct 22, 2020

@joschi

Closes #189

This pull request adds a diff analysis of operation ID. It is classified as a backwards compatible metdata change. Tests also included.

Besides of this PR: what a great library. Thanks a lot for creating and maintaining this. Even creating the PR was a joy thanks to the nice code layout :)

@joschi joschi self-assigned this Dec 6, 2020
Copy link
Collaborator

@joschi joschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiddewie Thanks for your contribution!

The PR looks good to me. 👍

@joschi joschi changed the title Feature: add diff results of operation ID (metadata) Add diff results of operation ID (metadata) Dec 6, 2020
@joschi joschi merged commit 0856ad6 into OpenAPITools:master Dec 6, 2020
@joschi joschi added this to the Release 2.0.0 milestone Dec 6, 2020
@hiddewie hiddewie deleted the feat-add-operation-id-diff branch March 29, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: compatibility detection for Operation ID
2 participants