Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix renderer memory issues by writing to OutputStream #544

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Fix renderer memory issues by writing to OutputStream #544

merged 1 commit into from
Jul 25, 2023

Conversation

LubomirS
Copy link
Contributor

@LubomirS LubomirS commented Jul 18, 2023 •
edited by joschi

This fixes the issue with large diffs, which are not possible to render #543

Closes #543

@LubomirS LubomirS changed the title fix(543): fix renderer memory issues by writing to file fix(543): fix renderer memory issues by writing to outputStream Jul 18, 2023
@joschi joschi self-assigned this Jul 25, 2023
@joschi joschi added this to the 2.1.0 milestone Jul 25, 2023
joschi
joschi approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@joschi joschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LubomirS Thanks a lot for your contribution!

@joschi joschi changed the title fix(543): fix renderer memory issues by writing to outputStream Fix renderer memory issues by writing to OutputStream Jul 25, 2023
@joschi joschi merged commit 830a887 into OpenAPITools:master Jul 25, 2023
5 checks passed
@LubomirS
Copy link
Contributor Author

@LubomirS Thanks a lot for your contribution!

thanks for the quick review @joschi 👍

@TheFreaky TheFreaky mentioned this pull request Dec 8, 2023
Closed
@joschi joschi mentioned this pull request Dec 16, 2023
Merged
joschi pushed a commit that referenced this pull request Dec 16, 2023
@TheFreaky
Fix console rendering (#595)
e40b07b 
This fixes console rendering:

- absence of "What's New", "What's Deleted", "What's Deprecated" sections
- Incorrect formatting in "What's Changed" section
- absence of "Result" title

Closes #594
Refs #544

Co-authored-by: Maksim Kuznetsov <mkuznetsov@natera.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joschi joschi joschi approved these changes

Assignees

@joschi joschi

Labels
enhancement
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Produce output to outputStream instead of String
2 participants
@LubomirS @joschi