-
Notifications
You must be signed in to change notification settings - Fork 171
Add maven release workflow #815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
snapshot uploaded successfully
ref: https://github.com/OpenAPITools/openapi-diff/actions/runs/17115851724/job/48546469970 |
@wing328 I would suggest removing release.yml as it is not needed anymore. Maybe it makes sense to have additional release job triggered manually? So it can handle version switching by parameters like we have before:
So on push to master snapshot version will be released automatically, but when we need to trigger release, it can be done manually. But this is up to you. |
Thanks for the review. Do we still need the workflow to publish the image to docker hub? That's the reason why I keep it. |
I see, we need for sure. Let's rename it then to "docker-release.yml" to make it clear. Feel free to merge. I will later think about a unified release job to invoke maven-release and docker-release at the same time. Just want to make it as simple as possible to perform the release with one click and not miss something. |
FYI. Renamed to docker-release.yml via #817 |
Add maven release workflow (github action) to replace existing workflows (commented out)