Skip to content

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Aug 21, 2025

Add maven release workflow (github action) to replace existing workflows (commented out)

@wing328 wing328 closed this Aug 21, 2025
@wing328 wing328 reopened this Aug 21, 2025
@wing328
Copy link
Member Author

wing328 commented Aug 21, 2025

snapshot uploaded successfully

[INFO] Installing /home/runner/work/openapi-diff/openapi-diff/maven-example/pom.xml to /home/runner/work/openapi-diff/openapi-diff/target/central-deferred/org/openapitools/openapidiff/openapi-diff-maven-example/2.2.0-SNAPSHOT/openapi-diff-maven-example-2.2.0-SNAPSHOT.pom
[INFO] Installing /home/runner/work/openapi-diff/openapi-diff/maven-example/target/openapi-diff-maven-example-2.2.0-SNAPSHOT.jar.asc to /home/runner/work/openapi-diff/openapi-diff/target/central-deferred/org/openapitools/openapidiff/openapi-diff-maven-example/2.2.0-SNAPSHOT/openapi-diff-maven-example-2.2.0-SNAPSHOT.jar.asc
[INFO] Installing /home/runner/work/openapi-diff/openapi-diff/maven-example/target/openapi-diff-maven-example-2.2.0-SNAPSHOT.pom.asc to /home/runner/work/openapi-diff/openapi-diff/target/central-deferred/org/openapitools/openapidiff/openapi-diff-maven-example/2.2.0-SNAPSHOT/openapi-diff-maven-example-2.2.0-SNAPSHOT.pom.asc
[INFO] Downloading from central: https://central.sonatype.com/repository/maven-snapshots/org/openapitools/openapidiff/openapi-diff-cli/2.2.0-SNAPSHOT/maven-metadata.xml
[INFO] Uploading to central: https://central.sonatype.com/repository/maven-snapshots/org/openapitools/openapidiff/openapi-diff-cli/2.2.0-SNAPSHOT/openapi-diff-cli-2.2.0-20250821.030005-1-sources.jar
[INFO] Uploaded to central: https://central.sonatype.com/repository/maven-snapshots/org/openapitools/openapidiff/openapi-diff-cli/2.2.0-SNAPSHOT/openapi-diff-cli-2.2.0-20250821.030005-1-sources.jar (5.5 kB at 3.3 kB/s)
[INFO] Downloading from central: https://central.sonatype.com/repository/maven-snapshots/org/openapitools/openapidiff/openapi-diff-cli/maven-metadata.xml
[INFO] Uploading to central: https://central.sonatype.com/repository/maven-snapshots/org/openapitools/openapidiff/openapi-diff-cli/2.2.0-SNAPSHOT/maven-metadata.xml
[INFO] Uploaded to central: https://central.sonatype.com/repository/maven-snapshots/org/openapitools/openapidiff/openapi-diff-cli/2.2.0-SNAPSHOT/maven-metadata.xml (662 B at 475 B/s)
[INFO] Uploading to central: https://central.sonatype.com/repository/maven-snapshots/org/openapitools/openapidiff/openapi-diff-cli/maven-metadata.xml
[INFO] Uploaded to central: https://central.sonatype.com/repository/maven-snapshots/org/openapitools/openapidiff/openapi-diff-cli/maven-metadata.xml (304 B at 218 B/s)
[INFO] Downloading from central: https://central.sonatype.com/repository/maven-snapshots/org/openapitools/openapidiff/openapi-diff-core/2.2.0-SNAPSHOT/maven-metadata.xml
[INFO] Uploading to central: https://central.sonatype.com/repository/maven-snapshots/org/openapitools/openapidiff/openapi-diff-core/2.2.0-SNAPSHOT/openapi-diff-core-2.2.0-20250821.030005-1-javadoc.jar
[INFO] Uploaded to central: https://central.sonatype.com/repository/maven-snapshots/org/openapitools/openapidiff/openapi-diff-core/2.2.0-SNAPSHOT/openapi-diff-core-2.2.0-20250821.030005-1-javadoc.jar (817 kB at 406 kB/s)
[INFO] Downloading from central: https://central.sonatype.com/repository/maven-snapshots/org/openapitools/openapidiff/openapi-diff-core/maven-metadata.xml
[INFO] Uploading to central: https://central.sonatype.com/repository/maven-snapshots/org/openapitools/openapidiff/openapi-diff-core/2.2.0-SNAPSHOT/maven-metadata.xml
[INFO] Uploaded to central: https://central.sonatype.com/repository/maven-snapshots/org/openapitools/openapidiff/openapi-diff-core/2.2.0-SNAPSHOT/maven-metadata.xml (663 B at 469 B/s)

ref: https://github.com/OpenAPITools/openapi-diff/actions/runs/17115851724/job/48546469970

@wing328 wing328 changed the title add maven release workflow dd maven release workflow Aug 21, 2025
@wing328 wing328 changed the title dd maven release workflow Add maven release workflow Aug 21, 2025
@wing328 wing328 marked this pull request as ready for review August 21, 2025 03:32
@DrSatyr
Copy link
Collaborator

DrSatyr commented Aug 21, 2025

@wing328 I would suggest removing release.yml as it is not needed anymore.

Maybe it makes sense to have additional release job triggered manually? So it can handle version switching by parameters like we have before:

on:
  workflow_dispatch:
    inputs:
      releaseVersion:
        description: 'Release version to tag (e.g., 2.1.0). Will be used for release artifacts and git tag.'
        required: true
      developmentVersion:
        description: 'Next development version (e.g., 2.2.0-SNAPSHOT). Will be used for continuing development after release.'
        required: true

So on push to master snapshot version will be released automatically, but when we need to trigger release, it can be done manually. But this is up to you.

@wing328
Copy link
Member Author

wing328 commented Aug 21, 2025

I would suggest removing release.yml as it is not needed anymore.

Thanks for the review. Do we still need the workflow to publish the image to docker hub? That's the reason why I keep it.

@DrSatyr
Copy link
Collaborator

DrSatyr commented Aug 21, 2025

Thanks for the review. Do we still need the workflow to publish the image to docker hub? That's the reason why I keep it.

I see, we need for sure. Let's rename it then to "docker-release.yml" to make it clear. Feel free to merge. I will later think about a unified release job to invoke maven-release and docker-release at the same time. Just want to make it as simple as possible to perform the release with one click and not miss something.

@wing328 wing328 merged commit 3e999a1 into master Aug 22, 2025
6 checks passed
@wing328 wing328 deleted the fix-release branch August 22, 2025 05:18
@wing328
Copy link
Member Author

wing328 commented Aug 22, 2025

FYI. Renamed to docker-release.yml via #817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants