Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scala] scala-akka-http-server support pekko-http using useApachePekko flag #16255

Merged
merged 3 commits into from
Aug 5, 2023

Conversation

krrrr38
Copy link
Contributor

@krrrr38 krrrr38 commented Aug 4, 2023

Closes #15924

pekko is a fork of akka. akka has a license problem, so someone wants to use pekko-http instead akka-http. Now pekko-http 1.0.0 is released, so openapi-generator can support pekko-http.

In this PR, add useApachePekko flag into scala-akka-http-server. When using it, the generator generates pekko-http src.

bin/configs/scala-pekko-http-server.yaml generates pekko-http sources and checks them in the ci.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@clasnake (2017/07), @jimschubert (2017/09) ❤️, @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03), @Bouillie (2020/04) @Fish86 (2023/06)

@krrrr38 krrrr38 force-pushed the scala-pekko-http-server branch 2 times, most recently from e093326 to 8dcc454 Compare August 4, 2023 11:54
@wing328 wing328 added this to the 7.0.0 milestone Aug 5, 2023
@wing328 wing328 merged commit c080660 into OpenAPITools:master Aug 5, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] Support scala-pekko-http-server instead scala-akka-http-server
2 participants