Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp] Move samples #18217

Merged
merged 34 commits into from
Mar 25, 2024
Merged

[csharp] Move samples #18217

merged 34 commits into from
Mar 25, 2024

Conversation

devhl-labs
Copy link
Contributor

@devhl-labs devhl-labs commented Mar 24, 2024

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Mar 24, 2024

mind elaborating on the change a bit?

changing 4000+ files is not easy to review :)

@devhl-labs
Copy link
Contributor Author

devhl-labs commented Mar 24, 2024

Everything under samples is only a rename. This changes the path of the samples so its like

samples
  client
    petstore
      csharp
        generichost
          net7
          net8
          standard2.0
        httpclient
          net7
          net8
          standard2.0
        restsharp
          net7
          net8
          standard2.0
        unityWebRequest
          net7
          net8
          standard2.0

image

@wing328
Copy link
Member

wing328 commented Mar 24, 2024

do we also need to update appveyor.yml?

@devhl-labs
Copy link
Contributor Author

Good call

@wing328
Copy link
Member

wing328 commented Mar 25, 2024

@wing328 wing328 merged commit d1860b9 into OpenAPITools:master Mar 25, 2024
22 checks passed
@devhl-labs devhl-labs deleted the move-samples branch March 25, 2024 01:21
@wing328 wing328 added this to the 7.5.0 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants