Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin: Do not escape/sanitize quoted enum values #18305

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Kotlin: Do not escape/sanitize quoted enum values #18305

merged 1 commit into from
Apr 7, 2024

Conversation

tajobe
Copy link
Contributor

@tajobe tajobe commented Apr 5, 2024

Stop escaping string enum values in the kotlin generator (#18107)

These values are arbitrary strings and shouldn't be manipulated, but currently get run through the same escape logic as the generated names for such values. I've updated the tests here to assert that the generate name is still appropriately escaped safely while leaving the values raw as intended.

See also #18107 for reproduction YAML.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Kotlin committee: @jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier

@wing328
Copy link
Member

wing328 commented Apr 7, 2024

lgtm thanks for the fix

@wing328 wing328 merged commit 560089e into OpenAPITools:master Apr 7, 2024
14 checks passed
@tajobe tajobe deleted the fix/18107/raw-string-enum-values branch April 8, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants