-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation with global propperty #6863
Conversation
FYI. @jimschubert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment, but it applies to multiple changes here
|
||
```sh | ||
# generate only models | ||
java -Dmodels {opts} | ||
--global-property models |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wing328 this charge isn't correct. The syntax in the README is system properties, and value-less properties like models/APIs can only be passed as system properties like exist in the README.
To change to our CLI args, any occurrence must follow the generate
CLI command and must have key=value syntax.
The reason our -D
option was removed from CLI is because people mistakenly thought this worked in any position and modified system properties similar to the mvn
app. Even I was confused by this when I began contributing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jimschubert Let's not advertise the usage of -D
(any position), shall we? The main reason is what you've pointed out - confusing.
PR checklist
./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*
. For Windows users, please run the script in Git BASH.master