-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Renames python generators #7965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loooks good to me!
What happened to the other generators? 😢
|
@ulgens when the If you need some good starting points to add back the support, please let me know. |
(Based on #7900 so credits go to @spacether)
This PR makes these generator changes
python
becomespython-legacy
python-experimental
becomespython
We are switching the python-experimental generator in as our stable python generator because it has significantly better composed schema support, many new features, and uses python3 only.
Some python (python-experimental) features
Also I improved string regex handling in python-legacy.
For python-legacy using the openapi (v3) spec sample tests of models have been regenerated and for non composed models, python-legacy now has auto-written tests that test instantiating a model instance with optional, and optional + required arguments. The regex fix was needed to get these tests passing.
PR checklist
./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH.master
Core Team
@wing328 (2015/07) ❤️
@jimschubert (2016/05) ❤️
@cbornet (2016/05)
@ackintosh (2018/02) ❤️
@jmini (2018/04) ❤️
@etherealjoy (2019/06)
@spacether (2020/05)