-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kotlin] add BigDecimal, BigInteger support #8880
[Kotlin] add BigDecimal, BigInteger support #8880
Conversation
db92665
to
247c200
Compare
Hey, thanks for your contribution 👍 |
it works if you add |
If I'm understanding what you are saying, it's possible to change the But by default it doesn't generate If by default the generator doesn't generate Also this PR adds the I'm not sure whats the right move here, let's here the other technical committee members. |
247c200
to
6958eeb
Compare
That was actually supposed to be in there, I let it slip through after rebasing, just pushed it in now. Thanks for catching that! |
@codymikol can you please resolve the merge conflicts when you've time? |
I'll take a look tomorrow |
this allows the kotlin client generator to support BigDecimal values Fixes OpenAPITools#7196
6958eeb
to
b965e5f
Compare
@wing328 sorry for the delay EDIT: Actually it looks like the CI is failing with some unrelated error, is this a problem for everyone? |
Updated the samples via 093d63b. Let's see if all the tests pass. |
Thanks wing 👍 |
this allows the kotlin client generator to support
BigDecimal values
This was originally created by @kuFEAR in their own branch, but a PR wasn't made into this project.
I hope you don't mind me making the PR for you, I happen to need this for my own project.
PR checklist
Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
File the PR against the correct branch:
master
,5.1.x
,6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. - [x]
Kotlin
@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)