Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove react-beautiful-dnd #839

Merged
merged 1 commit into from
May 26, 2023
Merged

Remove react-beautiful-dnd #839

merged 1 commit into from
May 26, 2023

Conversation

zichongkao
Copy link
Contributor

In response to #696 (comment).

Took the more conservative approach of editing CragTable instead of deprecating. In the long run, ClimbListPreview should be able to replace it, but there are some vital differences that make it hard to just drop it in. Notably, ClimbListPreview receives data from react-hook-form context instead of from its props.

@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
open-tacos ✅ Ready (Inspect) Visit Preview May 22, 2023 9:09pm

)}
</Droppable>
</DragDropContext>
<div className='grid grid-cols-1 lg:gap-3 xl:grid-cols-4 lg:grid-cols-3 md:grid-cols-2 fr-2'>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stripped out the drag and drop functionality, leaving it just as a read-only list.

@zichongkao zichongkao requested a review from vnugent May 22, 2023 21:11
@vnugent vnugent merged commit 5ef23fe into develop May 26, 2023
@vnugent vnugent deleted the kao-remove-dnd-beaut branch May 26, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants