Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] [API] Concept/Mapping versions should show there associations with Source/Collection versions #754

Closed
3 tasks done
snyaggarwal opened this issue May 12, 2021 · 5 comments
Closed
3 tasks done

[UI] [API] Concept/Mapping versions should show there associations with Source/Collection versions #754

snyaggarwal opened this issue May 12, 2021 · 5 comments
Assignees
@paynejd @snyaggarwal
Labels
api2 OCL API v2 enhancement New feature or request web2 OCL WEB v2
Milestone
Sprint 10

Comments

@snyaggarwal
Copy link
Contributor

Tasks

  • Concept/Mapping versions list and details to return urls of source/collections versions containing it.
  • Response field names - source_versions_associated_with and collection_versions_associated_with
  • Show the same in Concept/Mapping version history in UI
@snyaggarwal snyaggarwal added api2 OCL API v2 enhancement New feature or request web2 OCL WEB v2 labels May 12, 2021
@snyaggarwal snyaggarwal added this to the Sprint 10 milestone May 12, 2021
@snyaggarwal snyaggarwal self-assigned this May 12, 2021
@snyaggarwal
Copy link
Contributor Author

snyaggarwal commented May 12, 2021 •
edited
Loading

@paynejd This is how it will look like:
Screenshot 2021-05-13 at 12 46 38 AM
Screenshot 2021-05-13 at 12 50 40 AM

snyaggarwal added a commit to OpenConceptLab/oclapi2 that referenced this issue May 12, 2021
@snyaggarwal
OpenConceptLab/ocl_issues#754 | concept/mapping versions list to also…
8288d22 
… return source/collection version associations
snyaggarwal added a commit to OpenConceptLab/oclweb2 that referenced this issue May 12, 2021
@snyaggarwal
OpenConceptLab/ocl_issues#754 | concept/mapping versions should show …
671b4e8 
…associations in source/collection versions
snyaggarwal added a commit to OpenConceptLab/oclweb2 that referenced this issue May 12, 2021
@snyaggarwal
OpenConceptLab/ocl_issues#754 | using arrow tooltip
a38e0f8
snyaggarwal added a commit to OpenConceptLab/oclweb2 that referenced this issue May 12, 2021
@snyaggarwal
OpenConceptLab/ocl_issues#754 | using secondary color
96557be
snyaggarwal added a commit to OpenConceptLab/oclweb2 that referenced this issue May 13, 2021
@snyaggarwal
OpenConceptLab/ocl_issues#754 | correcting clickable region for assoc…
1bb68c7 
…iated Source/Collection
@jamlung-ri
Copy link
Member

jamlung-ri commented May 13, 2021 •
edited
Loading

@snyaggarwal This is looking good! For reference, I am looking at this concept from my own repo.

I have a couple of tweaks to suggest:

  • I see it says "Associated with 3", but just to be more clear, can it say instead "Associated with 3 versions"?
  • It might be helpful for retired concepts to have some formatting to show at what versions they were retired. Example from my own source: The version "meh" was when it was retired, so I wonder if it could have something to show that this is its retired version. (see picture for example, where I added the red Retired text)
    image

snyaggarwal added a commit to OpenConceptLab/oclweb2 that referenced this issue May 14, 2021
@snyaggarwal
OpenConceptLab/ocl_issues#754 | updated label for association
0a672e3
snyaggarwal added a commit to OpenConceptLab/oclweb2 that referenced this issue May 14, 2021
@snyaggarwal
OpenConceptLab/ocl_issues#754 | concept/mapping history | showing ret…
a045a16 
…ired label
@snyaggarwal
Copy link
Contributor Author

@jamlung-ri Added both the above suggestions

@jamlung-ri
Copy link
Member

Perfect, thanks!

snyaggarwal added a commit to OpenConceptLab/oclapi2 that referenced this issue May 16, 2021
@snyaggarwal
OpenConceptLab/ocl_issues#754 | refactored response attr names
19a43cd
snyaggarwal added a commit to OpenConceptLab/oclapi2 that referenced this issue May 16, 2021
@snyaggarwal
OpenConceptLab/ocl_issues#754 | mapping version detail serializer
b632cb2
snyaggarwal added a commit to OpenConceptLab/oclapi2 that referenced this issue May 16, 2021
@snyaggarwal
OpenConceptLab/ocl_issues#754 | concept/mapping versions | conditiona…
45da8d3 
…l include of source/collection versions in list responses
snyaggarwal added a commit to OpenConceptLab/oclapi2 that referenced this issue May 16, 2021
@snyaggarwal
OpenConceptLab/ocl_issues#754 | added include source/collection versi…
7097404 
…ons query param in swagger
@snyaggarwal
Copy link
Contributor Author

@paynejd
Updated the request to use conditional query params to get this in response (same goes for mappings):
GET /users/ocladmin/sources/test4/concepts/c1/versions/?includeSourceVersions=true&includeCollectionVersions=true

snyaggarwal added a commit to OpenConceptLab/oclweb2 that referenced this issue May 16, 2021
@snyaggarwal
OpenConceptLab/ocl_issues#754 | added include source/collection versi…
fc2fd58 
…ons query param in swagger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paynejd paynejd

@snyaggarwal snyaggarwal

Labels
api2 OCL API v2 enhancement New feature or request web2 OCL WEB v2
Projects
None yet
Milestone
Sprint 10
Development

No branches or pull requests
3 participants
@paynejd @snyaggarwal @jamlung-ri