Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

includeMappings/includeInverseMappings for a collection's concept should use the collection's scope #823

Closed
paynejd opened this issue Jun 30, 2021 · 5 comments
Closed

includeMappings/includeInverseMappings for a collection's concept should use the collection's scope #823

paynejd opened this issue Jun 30, 2021 · 5 comments
Assignees
@snyaggarwal
Labels
api2 OCL API v2 enhancement New feature or request
Milestone
Sprint 15

Comments

@paynejd
Copy link
Member

paynejd commented Jun 30, 2021

When requesting a concept from a collection, the includeMappings and includeInverseMappings parameters return the list of mappings for the concept from its source, rather than the relevant mappings from within the collection.

For example: This request returns the same results as if requesting the mappings for this concept from CIEL.

GET /users/burke/collections/example/concepts/163577/?includeMappings=true&includeInverseMappings=true

cc @bmamlin
@snyaggarwal snyaggarwal added api2 OCL API v2 bug Something isn't working labels Jul 1, 2021
@snyaggarwal snyaggarwal added this to the Sprint 13 milestone Jul 1, 2021
@jamlung-ri
Copy link
Member

To discuss on next week's Dev Call

@jamlung-ri jamlung-ri modified the milestones: Sprint 13, Sprint 14 Jul 2, 2021
@snyaggarwal snyaggarwal added enhancement New feature or request and removed bug Something isn't working labels Jul 2, 2021
snyaggarwal added a commit to OpenConceptLab/oclapi2 that referenced this issue Jul 7, 2021
@snyaggarwal
OpenConceptLab/ocl_issues#823 | includeMappings/includeInverseMapping…
f91afba 
…s for a collection's concept will now use the collection's scope
@gracepotma
Copy link

gracepotma commented Jul 7, 2021 •
edited
Loading

Thank you so much for this!!! @ibacher and @suruchee are very excited to use this asap to set up the first version of concept customization. Really appreciate the work and thought that have gone into this! <3

@askanter
Copy link

askanter commented Jul 7, 2021

Just wanted to be sure that this fix does not allow concepts to be circulating that are labeled/mapped to CIEL but have been changed (without that change clearly identified as a change in the data). The follow-on work to capture and display the fact that it has changed can be later, but the data shouldn't be out there wrongly tagged as CIEL if possible

@paynejd paynejd modified the milestones: Sprint 14, Sprint 15 Jul 13, 2021
@bmamlin bmamlin mentioned this issue Jul 15, 2021
Closed
@bmamlin
Copy link

bmamlin commented Jul 15, 2021 •
edited
Loading

I was investigating this issue...

  • @paynejd identified a test collection on QA under Ian's account /users/ibacher/collections/IBT/concepts/ with a single CIEL concept and its 5 mappings.
  • As I started testing using Ian's collection on QA, I discovered a bug returning duplicate results (Unexpected duplicate result from collection concepts #846). So, I decided to first create a test case on Staging.
  • I created a test collection on Staging and added the same CIEL concept – Acute Bronchitis (10) – Ian was using, cascading its 5 mappings. There are 5 mappings for this concept; four SAME-AS and one NARROWER-THAN.
  • I deleted the one NARROWER-THAN mapping within my test collection.
  • At this point, the original CIEL concept has 5 mappings (including a NARROW-THAN mapping) and the concept within my test collection should have 4 mappings (no NARROWER-THAN entry).

Based on this ticket, I was expecting an API request to concept 10 within my test collection with ?includeMappings=true to incorrectly return CIEL's five mappings instead of four (assuming the fix mentioned here is still only on QA)... but it works as expected.

https://api.staging.openconceptlab.org/users/burke/collections/test/concepts/?includeMappings=true

Click for response (notice 4 mappings, no NARROWER-THAN mapping) 
{
    "concept_class": "Diagnosis",
    "created_by": "burke",
    "created_on": "2021-07-12T17:03:59.483788Z",
    "datatype": "N/A",
    "descriptions": [
        {
            "description": "Lower respiratory infection of the bronchial tubes, acute.",
            "description_type": null,
            "external_id": "10FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF",
            "locale": "en",
            "locale_preferred": false,
            "type": "ConceptDescription",
            "uuid": "188355593"
        },
        {
            "description": "گلے کے نیچے سانس کی نالیوں کا ایسا انفیکشن جو دنوں یا ہفتوں میں ہوا ہو",
            "description_type": null,
            "external_id": "18137FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF",
            "locale": "ur",
            "locale_preferred": false,
            "type": "ConceptDescription",
            "uuid": "188355594"
        }
    ],
    "display_locale": "en",
    "display_name": "Acute bronchitis",
    "external_id": "10AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA",
    "extras": {},
    "hierarchy_path": null,
    "id": "10",
    "internal_reference_id": "2524685",
    "mappings": [
        {
            "created_by": "burke",
            "created_on": "2021-07-12T18:11:50.683720Z",
            "external_id": "69991ABBBBBBBBBBBBBBBBBBBBBBBBBBBBBB",
            "extras": {},
            "from_concept_code": "10",
            "from_concept_name": null,
            "from_concept_name_resolved": "Acute bronchitis",
            "from_concept_url": "/orgs/CIEL/sources/CIEL/concepts/10/",
            "from_source_name": "CIEL",
            "from_source_owner": "CIEL",
            "from_source_owner_type": "Organization",
            "from_source_url": "/orgs/CIEL/sources/CIEL/",
            "from_source_version": null,
            "id": "841008",
            "internal_reference_id": "2345611",
            "is_latest_version": true,
            "map_type": "SAME-AS",
            "owner": "CIEL",
            "owner_type": "Organization",
            "retired": false,
            "source": "CIEL",
            "to_concept_code": "10509002",
            "to_concept_name": null,
            "to_concept_url": null,
            "to_source_name": "SNOMED-CT",
            "to_source_owner": "IHTSDO",
            "to_source_owner_type": "Organization",
            "to_source_url": "/orgs/IHTSDO/sources/SNOMED-CT/",
            "to_source_version": null,
            "type": "Mapping",
            "update_comment": null,
            "updated_by": "burke",
            "updated_on": "2021-07-12T18:11:50.689282Z",
            "url": "/orgs/CIEL/sources/CIEL/mappings/841008/",
            "uuid": "2345611",
            "version": "2345611",
            "version_created_on": "2021-07-12T18:11:50.683720Z",
            "version_url": "/orgs/CIEL/sources/CIEL/mappings/841008/2345611/",
            "versioned_object_id": 841008,
            "versioned_object_url": "/orgs/CIEL/sources/CIEL/mappings/841008/"
        },
        {
            "created_by": "burke",
            "created_on": "2021-07-12T18:11:50.702017Z",
            "external_id": "133876ABBBBBBBBBBBBBBBBBBBBBBBBBBBBB",
            "extras": {},
            "from_concept_code": "10",
            "from_concept_name": null,
            "from_concept_name_resolved": "Acute bronchitis",
            "from_concept_url": "/orgs/CIEL/sources/CIEL/concepts/10/",
            "from_source_name": "CIEL",
            "from_source_owner": "CIEL",
            "from_source_owner_type": "Organization",
            "from_source_url": "/orgs/CIEL/sources/CIEL/",
            "from_source_version": null,
            "id": "840606",
            "internal_reference_id": "2345612",
            "is_latest_version": true,
            "map_type": "SAME-AS",
            "owner": "CIEL",
            "owner_type": "Organization",
            "retired": false,
            "source": "CIEL",
            "to_concept_code": "10",
            "to_concept_name": null,
            "to_concept_url": null,
            "to_source_name": "AMPATH",
            "to_source_owner": "AMPATH",
            "to_source_owner_type": "Organization",
            "to_source_url": "/orgs/AMPATH/sources/AMPATH/",
            "to_source_version": null,
            "type": "Mapping",
            "update_comment": null,
            "updated_by": "burke",
            "updated_on": "2021-07-12T18:11:50.703791Z",
            "url": "/orgs/CIEL/sources/CIEL/mappings/840606/",
            "uuid": "2345612",
            "version": "2345612",
            "version_created_on": "2021-07-12T18:11:50.702017Z",
            "version_url": "/orgs/CIEL/sources/CIEL/mappings/840606/2345612/",
            "versioned_object_id": 840606,
            "versioned_object_url": "/orgs/CIEL/sources/CIEL/mappings/840606/"
        },
        {
            "created_by": "burke",
            "created_on": "2021-07-12T18:11:50.843541Z",
            "external_id": "107175ABBBBBBBBBBBBBBBBBBBBBBBBBBBBB",
            "extras": {},
            "from_concept_code": "10",
            "from_concept_name": null,
            "from_concept_name_resolved": "Acute bronchitis",
            "from_concept_url": "/orgs/CIEL/sources/CIEL/concepts/10/",
            "from_source_name": "CIEL",
            "from_source_owner": "CIEL",
            "from_source_owner_type": "Organization",
            "from_source_url": "/orgs/CIEL/sources/CIEL/",
            "from_source_version": null,
            "id": "840580",
            "internal_reference_id": "2345615",
            "is_latest_version": true,
            "map_type": "SAME-AS",
            "owner": "CIEL",
            "owner_type": "Organization",
            "retired": false,
            "source": "CIEL",
            "to_concept_code": "J20.9",
            "to_concept_name": null,
            "to_concept_url": null,
            "to_source_name": "ICD-10-WHO",
            "to_source_owner": "WHO",
            "to_source_owner_type": "Organization",
            "to_source_url": "/orgs/WHO/sources/ICD-10-WHO/",
            "to_source_version": null,
            "type": "Mapping",
            "update_comment": null,
            "updated_by": "burke",
            "updated_on": "2021-07-12T18:11:50.847404Z",
            "url": "/orgs/CIEL/sources/CIEL/mappings/840580/",
            "uuid": "2345615",
            "version": "2345615",
            "version_created_on": "2021-07-12T18:11:50.843541Z",
            "version_url": "/orgs/CIEL/sources/CIEL/mappings/840580/2345615/",
            "versioned_object_id": 840580,
            "versioned_object_url": "/orgs/CIEL/sources/CIEL/mappings/840580/"
        },
        {
            "created_by": "burke",
            "created_on": "2021-07-12T18:11:50.959310Z",
            "external_id": "272147ABBBBBBBBBBBBBBBBBBBBBBBBBBBBB",
            "extras": {},
            "from_concept_code": "10",
            "from_concept_name": null,
            "from_concept_name_resolved": "Acute bronchitis",
            "from_concept_url": "/orgs/CIEL/sources/CIEL/concepts/10/",
            "from_source_name": "CIEL",
            "from_source_owner": "CIEL",
            "from_source_owner_type": "Organization",
            "from_source_url": "/orgs/CIEL/sources/CIEL/",
            "from_source_version": null,
            "id": "840585",
            "internal_reference_id": "2345617",
            "is_latest_version": true,
            "map_type": "SAME-AS",
            "owner": "CIEL",
            "owner_type": "Organization",
            "retired": false,
            "source": "CIEL",
            "to_concept_code": "58543",
            "to_concept_name": null,
            "to_concept_url": null,
            "to_source_name": "IMO-ProblemIT",
            "to_source_owner": "IMO",
            "to_source_owner_type": "Organization",
            "to_source_url": "/orgs/IMO/sources/IMO-ProblemIT/",
            "to_source_version": null,
            "type": "Mapping",
            "update_comment": null,
            "updated_by": "burke",
            "updated_on": "2021-07-12T18:11:50.967717Z",
            "url": "/orgs/CIEL/sources/CIEL/mappings/840585/",
            "uuid": "2345617",
            "version": "2345617",
            "version_created_on": "2021-07-12T18:11:50.959310Z",
            "version_url": "/orgs/CIEL/sources/CIEL/mappings/840585/2345617/",
            "versioned_object_id": 840585,
            "versioned_object_url": "/orgs/CIEL/sources/CIEL/mappings/840585/"
        }
    ],
    "name": "",
    "names": [
        {
            "external_id": "10BBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB",
            "locale": "en",
            "locale_preferred": true,
            "name": "Acute bronchitis",
            "name_type": "FULLY_SPECIFIED",
            "type": "ConceptName",
            "uuid": "188355586"
        },
        {
            "external_id": "80542BBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB",
            "locale": "es",
            "locale_preferred": true,
            "name": "bronquitis aguda",
            "name_type": "FULLY_SPECIFIED",
            "type": "ConceptName",
            "uuid": "188355587"
        },
        {
            "external_id": "87289BBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB",
            "locale": "en",
            "locale_preferred": false,
            "name": "Bronchitis, acute",
            "name_type": null,
            "type": "ConceptName",
            "uuid": "188355590"
        },
        {
            "external_id": "106371BBBBBBBBBBBBBBBBBBBBBBBBBBBBBB",
            "locale": "fr",
            "locale_preferred": true,
            "name": "Bronchite aigue",
            "name_type": "FULLY_SPECIFIED",
            "type": "ConceptName",
            "uuid": "188355591"
        },
        {
            "external_id": "139764BBBBBBBBBBBBBBBBBBBBBBBBBBBBBB",
            "locale": "ur",
            "locale_preferred": true,
            "name": "سانس کی نالی کا ایسا انفیکشن جو دنوں یا ہفتوں میں ہوا ہو",
            "name_type": "FULLY_SPECIFIED",
            "type": "ConceptName",
            "uuid": "188355592"
        }
    ],
    "owner": "CIEL",
    "owner_type": "Organization",
    "owner_url": "/orgs/CIEL/",
    "retired": false,
    "source": "CIEL",
    "type": "Concept",
    "update_comment": null,
    "updated_by": "burke",
    "updated_on": "2021-07-12T17:03:59.487470Z",
    "url": "/orgs/CIEL/sources/CIEL/concepts/10/",
    "uuid": "2524685",
    "version": "2524685",
    "version_url": "/orgs/CIEL/sources/CIEL/concepts/10/2524685/",
    "versions_url": "/orgs/CIEL/sources/CIEL/concepts/10/versions/"
}

as compared to the original CIEL concept here:

https://api.staging.openconceptlab.org/orgs/CIEL/sources/CIEL/concepts/10/?includeMappings=true

Click for response (notice 5 mappings, including NARROWER-THAN mapping) 
{
    "concept_class": "Diagnosis",
    "created_by": "ocladmin",
    "created_on": "2021-03-31T10:48:51.535349Z",
    "datatype": "N/A",
    "descriptions": [
        {
            "description": "Lower respiratory infection of the bronchial tubes, acute.",
            "description_type": null,
            "external_id": "10FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF",
            "locale": "en",
            "locale_preferred": false,
            "type": "ConceptDescription",
            "uuid": "188355593"
        },
        {
            "description": "گلے کے نیچے سانس کی نالیوں کا ایسا انفیکشن جو دنوں یا ہفتوں میں ہوا ہو",
            "description_type": null,
            "external_id": "18137FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF",
            "locale": "ur",
            "locale_preferred": false,
            "type": "ConceptDescription",
            "uuid": "188355594"
        }
    ],
    "display_locale": "en",
    "display_name": "Acute bronchitis",
    "external_id": "10AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA",
    "extras": {},
    "hierarchy_path": null,
    "id": "10",
    "internal_reference_id": "57cd60ebfffcf000075be086",
    "mappings": [
        {
            "created_by": "ocladmin",
            "created_on": "2021-03-31T11:01:35.659438Z",
            "external_id": "272147ABBBBBBBBBBBBBBBBBBBBBBBBBBBBB",
            "extras": {},
            "from_concept_code": "10",
            "from_concept_name": null,
            "from_concept_name_resolved": "Acute bronchitis",
            "from_concept_url": "/orgs/CIEL/sources/CIEL/concepts/10/",
            "from_source_name": "CIEL",
            "from_source_owner": "CIEL",
            "from_source_owner_type": "Organization",
            "from_source_url": "/orgs/CIEL/sources/CIEL/",
            "from_source_version": null,
            "id": "840585",
            "internal_reference_id": "840585",
            "is_latest_version": false,
            "map_type": "SAME-AS",
            "owner": "CIEL",
            "owner_type": "Organization",
            "retired": false,
            "source": "CIEL",
            "to_concept_code": "58543",
            "to_concept_name": null,
            "to_concept_url": null,
            "to_source_name": "IMO-ProblemIT",
            "to_source_owner": "IMO",
            "to_source_owner_type": "Organization",
            "to_source_url": "/orgs/IMO/sources/IMO-ProblemIT/",
            "to_source_version": null,
            "type": "Mapping",
            "update_comment": null,
            "updated_by": "ocladmin",
            "updated_on": "2021-07-12T18:11:50.986368Z",
            "url": "/orgs/CIEL/sources/CIEL/mappings/840585/",
            "uuid": "840585",
            "version": "840585",
            "version_created_on": "2021-03-31T11:01:35.659438Z",
            "version_url": "/orgs/CIEL/sources/CIEL/mappings/840585/2345617/",
            "versioned_object_id": 840585,
            "versioned_object_url": "/orgs/CIEL/sources/CIEL/mappings/840585/"
        },
        {
            "created_by": "ocladmin",
            "created_on": "2021-03-31T11:01:35.557202Z",
            "external_id": "107175ABBBBBBBBBBBBBBBBBBBBBBBBBBBBB",
            "extras": {},
            "from_concept_code": "10",
            "from_concept_name": null,
            "from_concept_name_resolved": "Acute bronchitis",
            "from_concept_url": "/orgs/CIEL/sources/CIEL/concepts/10/",
            "from_source_name": "CIEL",
            "from_source_owner": "CIEL",
            "from_source_owner_type": "Organization",
            "from_source_url": "/orgs/CIEL/sources/CIEL/",
            "from_source_version": null,
            "id": "840580",
            "internal_reference_id": "840580",
            "is_latest_version": false,
            "map_type": "SAME-AS",
            "owner": "CIEL",
            "owner_type": "Organization",
            "retired": false,
            "source": "CIEL",
            "to_concept_code": "J20.9",
            "to_concept_name": null,
            "to_concept_url": null,
            "to_source_name": "ICD-10-WHO",
            "to_source_owner": "WHO",
            "to_source_owner_type": "Organization",
            "to_source_url": "/orgs/WHO/sources/ICD-10-WHO/",
            "to_source_version": null,
            "type": "Mapping",
            "update_comment": null,
            "updated_by": "ocladmin",
            "updated_on": "2021-07-12T18:11:50.858273Z",
            "url": "/orgs/CIEL/sources/CIEL/mappings/840580/",
            "uuid": "840580",
            "version": "840580",
            "version_created_on": "2021-03-31T11:01:35.557202Z",
            "version_url": "/orgs/CIEL/sources/CIEL/mappings/840580/2345615/",
            "versioned_object_id": 840580,
            "versioned_object_url": "/orgs/CIEL/sources/CIEL/mappings/840580/"
        },
        {
            "created_by": "ocladmin",
            "created_on": "2021-03-31T11:01:35.887627Z",
            "external_id": "133876ABBBBBBBBBBBBBBBBBBBBBBBBBBBBB",
            "extras": {},
            "from_concept_code": "10",
            "from_concept_name": null,
            "from_concept_name_resolved": "Acute bronchitis",
            "from_concept_url": "/orgs/CIEL/sources/CIEL/concepts/10/",
            "from_source_name": "CIEL",
            "from_source_owner": "CIEL",
            "from_source_owner_type": "Organization",
            "from_source_url": "/orgs/CIEL/sources/CIEL/",
            "from_source_version": null,
            "id": "840606",
            "internal_reference_id": "840606",
            "is_latest_version": false,
            "map_type": "SAME-AS",
            "owner": "CIEL",
            "owner_type": "Organization",
            "retired": false,
            "source": "CIEL",
            "to_concept_code": "10",
            "to_concept_name": null,
            "to_concept_url": null,
            "to_source_name": "AMPATH",
            "to_source_owner": "AMPATH",
            "to_source_owner_type": "Organization",
            "to_source_url": "/orgs/AMPATH/sources/AMPATH/",
            "to_source_version": null,
            "type": "Mapping",
            "update_comment": null,
            "updated_by": "ocladmin",
            "updated_on": "2021-07-12T18:11:50.707959Z",
            "url": "/orgs/CIEL/sources/CIEL/mappings/840606/",
            "uuid": "840606",
            "version": "840606",
            "version_created_on": "2021-03-31T11:01:35.887627Z",
            "version_url": "/orgs/CIEL/sources/CIEL/mappings/840606/2345612/",
            "versioned_object_id": 840606,
            "versioned_object_url": "/orgs/CIEL/sources/CIEL/mappings/840606/"
        },
        {
            "created_by": "ocladmin",
            "created_on": "2021-03-31T11:01:39.060322Z",
            "external_id": "69991ABBBBBBBBBBBBBBBBBBBBBBBBBBBBBB",
            "extras": {},
            "from_concept_code": "10",
            "from_concept_name": null,
            "from_concept_name_resolved": "Acute bronchitis",
            "from_concept_url": "/orgs/CIEL/sources/CIEL/concepts/10/",
            "from_source_name": "CIEL",
            "from_source_owner": "CIEL",
            "from_source_owner_type": "Organization",
            "from_source_url": "/orgs/CIEL/sources/CIEL/",
            "from_source_version": null,
            "id": "841008",
            "internal_reference_id": "841008",
            "is_latest_version": false,
            "map_type": "SAME-AS",
            "owner": "CIEL",
            "owner_type": "Organization",
            "retired": false,
            "source": "CIEL",
            "to_concept_code": "10509002",
            "to_concept_name": null,
            "to_concept_url": null,
            "to_source_name": "SNOMED-CT",
            "to_source_owner": "IHTSDO",
            "to_source_owner_type": "Organization",
            "to_source_url": "/orgs/IHTSDO/sources/SNOMED-CT/",
            "to_source_version": null,
            "type": "Mapping",
            "update_comment": null,
            "updated_by": "ocladmin",
            "updated_on": "2021-07-12T18:11:50.696440Z",
            "url": "/orgs/CIEL/sources/CIEL/mappings/841008/",
            "uuid": "841008",
            "version": "841008",
            "version_created_on": "2021-03-31T11:01:39.060322Z",
            "version_url": "/orgs/CIEL/sources/CIEL/mappings/841008/2345611/",
            "versioned_object_id": 841008,
            "versioned_object_url": "/orgs/CIEL/sources/CIEL/mappings/841008/"
        },
        {
            "created_by": "ocladmin",
            "created_on": "2021-03-31T11:01:35.655507Z",
            "external_id": "80189ABBBBBBBBBBBBBBBBBBBBBBBBBBBBBB",
            "extras": {},
            "from_concept_code": "10",
            "from_concept_name": null,
            "from_concept_name_resolved": "Acute bronchitis",
            "from_concept_url": "/orgs/CIEL/sources/CIEL/concepts/10/",
            "from_source_name": "CIEL",
            "from_source_owner": "CIEL",
            "from_source_owner_type": "Organization",
            "from_source_url": "/orgs/CIEL/sources/CIEL/",
            "from_source_version": null,
            "id": "840583",
            "internal_reference_id": "840583",
            "is_latest_version": false,
            "map_type": "NARROWER-THAN",
            "owner": "CIEL",
            "owner_type": "Organization",
            "retired": false,
            "source": "CIEL",
            "to_concept_code": "13645005",
            "to_concept_name": null,
            "to_concept_url": null,
            "to_source_name": "SNOMED-CT",
            "to_source_owner": "IHTSDO",
            "to_source_owner_type": "Organization",
            "to_source_url": "/orgs/IHTSDO/sources/SNOMED-CT/",
            "to_source_version": null,
            "type": "Mapping",
            "update_comment": null,
            "updated_by": "ocladmin",
            "updated_on": "2021-07-12T18:11:50.643085Z",
            "url": "/orgs/CIEL/sources/CIEL/mappings/840583/",
            "uuid": "840583",
            "version": "840583",
            "version_created_on": "2021-03-31T11:01:35.655507Z",
            "version_url": "/orgs/CIEL/sources/CIEL/mappings/840583/2345610/",
            "versioned_object_id": 840583,
            "versioned_object_url": "/orgs/CIEL/sources/CIEL/mappings/840583/"
        }
    ],
    "name": "10",
    "names": [
        {
            "external_id": "10BBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB",
            "locale": "en",
            "locale_preferred": true,
            "name": "Acute bronchitis",
            "name_type": "FULLY_SPECIFIED",
            "type": "ConceptName",
            "uuid": "188355586"
        },
        {
            "external_id": "80542BBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB",
            "locale": "es",
            "locale_preferred": true,
            "name": "bronquitis aguda",
            "name_type": "FULLY_SPECIFIED",
            "type": "ConceptName",
            "uuid": "188355587"
        },
        {
            "external_id": "87289BBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB",
            "locale": "en",
            "locale_preferred": false,
            "name": "Bronchitis, acute",
            "name_type": null,
            "type": "ConceptName",
            "uuid": "188355590"
        },
        {
            "external_id": "106371BBBBBBBBBBBBBBBBBBBBBBBBBBBBBB",
            "locale": "fr",
            "locale_preferred": true,
            "name": "Bronchite aigue",
            "name_type": "FULLY_SPECIFIED",
            "type": "ConceptName",
            "uuid": "188355591"
        },
        {
            "external_id": "139764BBBBBBBBBBBBBBBBBBBBBBBBBBBBBB",
            "locale": "ur",
            "locale_preferred": true,
            "name": "سانس کی نالی کا ایسا انفیکشن جو دنوں یا ہفتوں میں ہوا ہو",
            "name_type": "FULLY_SPECIFIED",
            "type": "ConceptName",
            "uuid": "188355592"
        }
    ],
    "owner": "CIEL",
    "owner_type": "Organization",
    "owner_url": "/orgs/CIEL/",
    "retired": false,
    "source": "CIEL",
    "type": "Concept",
    "update_comment": null,
    "updated_by": "ocladmin",
    "updated_on": "2021-07-12T17:03:59.641932Z",
    "url": "/orgs/CIEL/sources/CIEL/concepts/10/",
    "uuid": "307668",
    "version": "307668",
    "version_url": "/orgs/CIEL/sources/CIEL/concepts/10/2524685/",
    "versions_url": "/orgs/CIEL/sources/CIEL/concepts/10/versions/"
}

@paynejd is the issue only with dynamic references?

Just wanted to be sure that this fix does not allow concepts to be circulating that are labeled/mapped to CIEL but have been changed (without that change clearly identified as a change in the data). The follow-on work to capture and display the fact that it has changed can be later, but the data shouldn't be out there wrongly tagged as CIEL if possible

@askanter the customized concept is fetched from /burke/collections/test/concepts/10/ instead of /CIEL/sources/CIEL/concepts/10, but – to your point – we'll want to be sure that the difference is clear in the response (payload) as well.

@paynejd
Copy link
Member Author

paynejd commented Jul 26, 2021

@bmamlin I think that we discovered that the feature had already been deployed to staging at the time that you were testing, which means that you verified that the new behavior is as expected. I believe that we can close this out

@paynejd paynejd closed this as completed Jul 29, 2021
@snyaggarwal snyaggarwal mentioned this issue Aug 4, 2021
Closed
@jamlung-ri jamlung-ri mentioned this issue Sep 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snyaggarwal snyaggarwal

Labels
api2 OCL API v2 enhancement New feature or request
Projects
None yet
Milestone
Sprint 15
Development

No branches or pull requests
6 participants
@bmamlin @paynejd @snyaggarwal @askanter @jamlung-ri @gracepotma