update to latest yocto release + version bump of opendds #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honister is EOL Nambield is latest release Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com>
Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com>
Fixed a few linting warnings with oelint_adv: opendds.inc:9:info:oelint.vars.notneededspace:Space at the beginning of the var is not needed opendds.inc:9:error:oelint.vars.inconspaces:Assignment should be 'VAR += "foo"' not 'VAR += " foo"' opendds.inc:9:warning:oelint.vars.dependsordered:'DEPENDS' entries should be ordered alphabetically opendds.inc:9:error:oelint.spaces.linecont:No spaces after line continuation opendds.inc:14:warning:oelint.spaces.lineend:Line shall not end with a space opendds.inc:17:warning:oelint.vars.dependsordered:'RDEPENDS' entries should be ordered alphabetically opendds.inc:17:info:oelint.vars.notneededspace:Space at the beginning of the var is not needed opendds.inc:17:error:oelint.vars.inconspaces:Assignment should be 'VAR += "foo"' not 'VAR += " foo"' opendds_3.26.1.bb:19:warning:oelint.spaces.lineend:Line shall not end with a space opendds_3.26.1.bb:20:warning:oelint.spaces.lineend:Line shall not end with a space opendds_git.bb:20:info:oelint.vars.notneededspace:Space at the beginning of the var is not needed Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com>
mitza-oci
approved these changes
Dec 28, 2023
Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com>
|
@mitza-oci Did another small commit to set the version in the readme correct |
and one linting issue fixed... info:oelint.var.suggestedvar.BUGTRACKER:Variable 'BUGTRACKER' should be set Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com>
mitza-oci
reviewed
Jan 2, 2024
|
Hi,
It should be the bug tracker of the recipe. So OpenDDS, as it is.
https://docs.yoctoproject.org/singleindex.html#term-BUGTRACKER
I assume the info the user would like to find about the meta layer itself
is in the readme.md file.
Br and my best wishes for 2024
…On Tue, Jan 2, 2024 at 3:47 PM Adam Mitz ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In recipes-connectivity/opendds/opendds.inc
<#34 (comment)>:
> @@ -1,5 +1,6 @@
SUMMARY = "OpenDDS is an open source C++ implementation of the Object Management Group (OMG) Data Distribution Service (DDS)"
HOMEPAGE = "https://opendds.org"
+BUGTRACKER = "https://github.com/OpenDDS/OpenDDS/issues"
Should this be OpenDDS/meta-opendds? -- if users have problems they should
probably start here
—
Reply to this email directly, view it on GitHub
<#34 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5IFKXAIXKAWJ2DCUQXM3LYMQMYJAVCNFSM6AAAAABBFK3QF6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMBQGUZTMMRUGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Jan Vermaete
“Success is a self-correcting phenomenom.” -- Gary Hamel
|
Current version of gcc in yocto at master was having a compilation issue. Patch is already applied upstream and will probably be part of the next release. Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com>
|
hi @mitza-oci With my last commit the master, latest release and LTS release of Yocto should work. Next on my list is:
|
Looks good to me. @plabanca would you please review? If you don't have time we can probably merge anyway. |
jrw972
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description how to contribute in the readme.md file could be updated?