Skip to content

Conversation

andylolz
Copy link
Contributor

@andylolz andylolz commented Aug 9, 2017

Refs #148.

@timgdavies
Copy link
Contributor

@andylolz This looks good - and a good fix for now. There's a branch I'm working on where I hope to introduce an editing interface in near future - but not quite ready.

@Bjwebb Can you see why the Travis tests are failing on this and whether we can get this merge-able?

@andylolz
Copy link
Contributor Author

andylolz commented Aug 9, 2017

Tests pass for me locally.

@Bjwebb
Copy link
Member

Bjwebb commented Aug 9, 2017

Tests fail due to travis IPs having hit the limit for github api requests.
I've added an API key so the tests pass for our pushes, but travis doesn't trust other people's pull requests with that key.

I've triggered a push run on travis and it passes. It's okay to merge this pull request.

@andylolz
Copy link
Contributor Author

andylolz commented Aug 9, 2017

@Bjwebb I guess you can git commit --amend --no-edit && git push --force origin to force a green tick here? Would that work? EDIT: Oh, I see – probably not. nvm!

@Bjwebb Bjwebb merged commit 62bb182 into OpenDataServices:master Aug 9, 2017
@andylolz andylolz deleted the 148-fix-links branch August 9, 2017 15:52
@Bjwebb
Copy link
Member

Bjwebb commented Aug 9, 2017

Deployed now to http://org-id.guide/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants