Skip to content

Make media query height- (not width-) dependent #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 17, 2017
Merged

Make media query height- (not width-) dependent #166

merged 3 commits into from
Oct 17, 2017

Conversation

andylolz
Copy link
Contributor

Refs #133.

@Bjwebb
Copy link
Member

Bjwebb commented Sep 27, 2017

Dev deploy of this at http://133-overlapping-footer.dev.org-id.guide/

@BobHarper1
Copy link
Contributor

My laptop likes it.

@andylolz
Copy link
Contributor Author

Thanks both – this looks good to me. While some viewport heights appear to break the version currently on http://dev.org-id.guide, the version on http://133-overlapping-footer.dev.org-id.guide looks unbreakable.

@Bjwebb Bjwebb merged commit b3b33e1 into OpenDataServices:master Oct 17, 2017
@andylolz andylolz deleted the 133-overlapping-footer branch October 17, 2017 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andylolz @Bjwebb @BobHarper1