-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Eames tower shadow model to AD15 #645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. Good job updating the documentation as well, and +1 for a couple of condensed error checking :)
I see this as an opportunity to start the theory manual. Maybe just adding a theory.rst
with a content along these lines?
.. _AD_theory:
AeroDynTheory
==========
This theory manual is work in progress, please refer to the AeroDyn manual for more details.
.. _AD_twr_shadow
Tower shadow models
~~~~~~~~~~~~~~~
Powles tower shadow model (**TwrShadow=1**) is given by:
.. math::
u_{TwrShadow} = - \frac{TwrCd}{ \sqrt{\overline{r}} } \cos( \pi/2 \overline{y}/\sqrt{\overline{r}})^2
,\qquad
\overline{r} = sqrt{ \overline{x}^2 + \overline{y}^2 } }
Eams tower shadow model (**TwrShadow=2**) is given by:
.. math::
u_{TwrShadow} = -\frac{C_d}{ TI \overline{x} \sqrt{2 \pi } } \exp{ -1/2 ( \overline{y} / (TI \overline{x}) )^2 }
8e23324
to
2ff9c6d
Compare
AD15 TwrShadow: add placeholder theory manual to docs AD15 TwrShadow: fix api_change.rst AD15 TwrShadow: docs update
b351cac
to
bf92048
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In input.rst, it says, "Update this statement after testing!!!!!!*" But the comment section of the pull request says testing was completed. Should this statement be deleted?
Looking at the source code, it looks like 0.05 < TI <= 0.4 is recommended.
Otherwise, everything else looks good and matches the implementation plan.
@jjonkman, good catch. I forgot about that comment in the docs. |
This pull request is ready for merging. Merge this after #643
Feature or improvement description
This pull request adds the Eames tower shadow model as an option in addition to the Powles model.
Impacted areas of the software
This only affects the available tower shadow model options used within AD15 and the AD15 input file format. This adds a new column to the tower properties table for the TI value to use with the Eames model.
Additional supporting information
This model was developed with the University of Virginia under the SOAR program. They completed testing of the model and set reasonable limits for the tower TI values.
Preliminary figures for comparison
Qualitatively, the Eames model returns something that is similar to the Powles model. For the testing, a TI value of 0.1 is used along the entire tower for the Eames model, with degrees of freedom to off in ElastoDyn. The plots below show the Fx, My, and Mz for blade 1 as a function of azimuth (0 azimuth is blade 1 pointed straight up).