Skip to content

Conversation

mroote
Copy link
Member

@mroote mroote commented Aug 8, 2019

Added a dockerfile to create the release packages and added a CI job to automatically upload releases if you tag the version.

@knoxfighter
Copy link
Member

It seems, like only go-1.10.x is tested!

@mroote mroote force-pushed the improve_ci_build branch 3 times, most recently from 4e6adce to 8daff75 Compare August 30, 2019 03:01
@mroote
Copy link
Member Author

mroote commented Aug 30, 2019

I got it working with multiple go versions now and removed some of the older versions. Windows seems to have issues making the builds though not sure what's up with that.

@knoxfighter
Copy link
Member

Windows has no "make" command: "/c/Users/travis/.travis/functions: line 104: make: command not found"
And the release should only work, when running on master-branch and successfully, in my opinion. Cause you crated a new Release, with this script (with wrong Patchnotes)

@knoxfighter
Copy link
Member

knoxfighter commented Oct 10, 2019

It took me some time, but know, i can understand travis files :)
I looked into this and tested it on my fork.
It has no make on windows. So the installation cannot be done with make godeps. Please change it to the install-step and manually add the go get <dep>.

Also, what is with the 0.8.3 release, that has no name or describtion?

@mroote
Copy link
Member Author

mroote commented Oct 10, 2019

That 0.8.3 release was just a tag created while I was testing by mistake, I've removed it now.

Nice yeah I'll have to update the build to use Go to download the deps. I'll look into migrating the deps to use Go modules instead now.

@knoxfighter
Copy link
Member

I also thought about using go deps instead, but when you do it, it is fine for me.
Also, the 0.8.2 release is based on this PR, not based on the master or develop-branch. I would say, we should create a new release, from the develop-branch and with a proper changelog :)

@mroote
Copy link
Member Author

mroote commented Oct 10, 2019

Yeah I agree once this build is working I'll merge this in and make a proper build off of develop.

@knoxfighter knoxfighter mentioned this pull request Oct 30, 2019
@mroote mroote merged commit 80cc8c3 into develop Jan 8, 2020
@knoxfighter knoxfighter deleted the improve_ci_build branch January 30, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants