Fixes NPE when a Response does not provide headers #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes OpenFeign#853 There are some scenarios reported where a server does not provide headers with the response. While this is not typically expected, it's simple enough for Feign to be resilient to it. This change checks the headers provided in the builder and if none are provided, an empty map is used in it's place.
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
Fixes #853 There are some scenarios reported where a server does not provide headers with the response. While this is not typically expected, it's simple enough for Feign to be resilient to it. This change checks the headers provided in the builder and if none are provided, an empty map is used in it's place.
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Fixes #853 There are some scenarios reported where a server does not provide headers with the response. While this is not typically expected, it's simple enough for Feign to be resilient to it. This change checks the headers provided in the builder and if none are provided, an empty map is used in it's place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #853
There are some scenarios reported where a server does
not provide headers with the response. While this is
not typically expected, it's simple enough for Feign to
be resilient to it. This change checks the headers provided
in the builder and if none are provided, an empty map is
used in it's place.