Fix critical time complexity issue of queue operation in python and javascript #6220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue:
A standard Queue data structure should have O(1) time complexity for all basic operations.
Since the following two operations take O(N) time:
self.data.insert(0, x)
in pythonstore.shift();
in javascriptThe time complexity of some
enqueue
anddequeue
operation will become O(N) instead of O(1)Changes:
Major:
enqueue
anddequeue
from O(N) to O(1).Minor:
top
operation for getting the top element from queue.array
) in python implementation.