Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer handlers empty and run as part of daemon handlers #3

Closed
jheusser opened this issue Oct 8, 2015 · 2 comments
Closed

Timer handlers empty and run as part of daemon handlers #3

jheusser opened this issue Oct 8, 2015 · 2 comments

Comments

@jheusser
Copy link

jheusser commented Oct 8, 2015

Maybe introduced as part of a refactor, but Timer handlers are run together with Daemon handlers (which is never if you are always busy) due to this switch case. Then consequently, the call to runTimerHandlers is empty in the hot method. Can submit a PR if you like.

@peter-lawrey
Copy link
Member

Please offer a pull request. The higher priority handlers shouldn't be
busy long, but this might be longer than the timer expects.

On 8 October 2015 at 12:31, Jonathan Heusser notifications@github.com
wrote:

Maybe introduced as part of a refactor, but Timer handlers are run
together with Daemon handlers (which is never if you are always busy) due
to this switch
https://github.com/OpenHFT/Chronicle-Threads/blob/master/src/main/java/net/openhft/chronicle/threads/VanillaEventLoop.java#L232
case. Then consequently, the call to runTimerHandlers is empty in the hot
method
https://github.com/OpenHFT/Chronicle-Threads/blob/master/src/main/java/net/openhft/chronicle/threads/VanillaEventLoop.java#L123.
Can submit a PR if you like.


Reply to this email directly or view it on GitHub
#3.

@peter-lawrey
Copy link
Member

This was fixed in January, I am sorry for taking so long to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants