Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common Yaml writer for TEXT and YAML wires. #411

Closed
alamar opened this issue Mar 11, 2022 · 0 comments
Closed

Common Yaml writer for TEXT and YAML wires. #411

alamar opened this issue Mar 11, 2022 · 0 comments
Assignees

Comments

@alamar
Copy link
Contributor

alamar commented Mar 11, 2022

Right now there's two parsers and each of those has a writer. They end up producing incorrect YAML in some cases, such as putting extra commas in key: value blocks.

There's a reason why there should be two parsers for now, but there's no reason to have more than one writer, which should be conservative in what it emits. In 2.24 one of writers may be removed.

alamar added a commit that referenced this issue Sep 26, 2022
Split out common YAML formatting code
closes #411
alamar added a commit to OpenHFT/Chronicle-Bytes that referenced this issue Sep 26, 2022
alamar added a commit to OpenHFT/Chronicle-Bytes that referenced this issue Sep 27, 2022
alamar added a commit that referenced this issue Sep 27, 2022
Split out common YAML formatting code
closes #411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant