Absorb missing (or not functioning) fallocate64. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Issue 31
james-mcsherry
approved these changes
May 30, 2024
JerryShea
approved these changes
May 31, 2024
alamar
approved these changes
Jun 3, 2024
tgd
approved these changes
Jun 3, 2024
…h unavailable ftruncate is more widely supported, and while not a strict replacement is close enough for most cases
|
@rogersimmons Thanks for the change. I was trying this out on Alpine Linux 3.19+ 64-bit and it seems that an I did notice the new changes catch java.lang.UnsatisfiedLinkError: Symbol not found: Java_com_kenai_jffi_Foreign_dlerror
at jnr.ffi.provider.jffi.AsmRuntime.newUnsatisifiedLinkError(AsmRuntime.java:48)
at net.openhft.posix.internal.jnr.JNRPosixInterface$jnr$ffi$0.fallocate64(Unknown Source)
at net.openhft.posix.internal.jnr.JNRPosixAPI.fallocate(JNRPosixAPI.java:244)
at net.openhft.chronicle.hash.impl.util.jna.PosixFallocate.fallocate(PosixFallocate.java:18)
at net.openhft.chronicle.hash.impl.VanillaChronicleHash.fallocate(VanillaChronicleHash.java:1109)
at net.openhft.chronicle.hash.impl.VanillaChronicleHash.map(VanillaChronicleHash.java:1095)
at net.openhft.chronicle.hash.impl.VanillaChronicleHash.createMappedStoreAndSegments(VanillaChronicleHash.java:516)
at net.openhft.chronicle.map.ChronicleMapBuilder.createWithNewFile(ChronicleMapBuilder.java:1824)
at net.openhft.chronicle.map.ChronicleMapBuilder.createWithFile(ChronicleMapBuilder.java:1722)
at net.openhft.chronicle.map.ChronicleMapBuilder.createPersistedTo(ChronicleMapBuilder.java:1585) |
|
Thank you @splunk-chowiel. |
|
@splunk-chowiel - for info, the fix for the UnsatisfiedLinkError is now available in release https://github.com/OpenHFT/Posix/releases/tag/posix-2.26ea2 |
tgd
pushed a commit
that referenced
this pull request
Nov 6, 2024
* Absorb missing (or not functioning) fallocate64. Fixes Issue 31 * Revert to ftruncate when possible in cases where fallocate/64 are both unavailable ftruncate is more widely supported, and while not a strict replacement is close enough for most cases --------- Co-authored-by: rogersimmons <roger.simmons@higherfrequencytrading.com>
tgd
added a commit
that referenced
this pull request
Nov 6, 2024
* Absorb missing (or not functioning) fallocate64. (#34) * Absorb missing (or not functioning) fallocate64. Fixes Issue 31 * Revert to ftruncate when possible in cases where fallocate/64 are both unavailable ftruncate is more widely supported, and while not a strict replacement is close enough for most cases --------- Co-authored-by: rogersimmons <roger.simmons@higherfrequencytrading.com> * Extend exception/error handling on speculative fallocate64 calls etc (#39) Co-authored-by: rogersimmons <roger.simmons@higherfrequencytrading.com> * More graceful, slightly safer failback if fallocate not supported (#40) Co-authored-by: rogersimmons <roger.simmons@higherfrequencytrading.com> --------- Co-authored-by: rogersimmons <42873823+rogersimmons@users.noreply.github.com> Co-authored-by: rogersimmons <roger.simmons@higherfrequencytrading.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue 31