-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗🔧:polish off the tasking with prettify #483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there,
Great job on the changes so far! I noticed a few things that we need to address:
- In the
moon.yml
file, theinputs
andoutputs
for each task have been duplicated unintentionally. This could potentially cause issues. Please review and remove the duplicated lines.
Here's an example of what you need to fix:
verify-css:
command: moon run verify.css
inputs:
- '**/*.css'
inputs: # <-- This is duplicated
- '**/*.css'
Please apply this fix to all tasks in the moon.yml
file.
Keep up the good work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the issue not understood?
Description
This PR aims to improve the tasking structure in the repository by implementing the changes proposed in this pull request. The current tasking situation is incomplete and uses the
nps
solution, which is still functional but needs to be updated. The goal is to make the tasking structure more impressive and ready for org-wide adoption.Changes Made
moon.yml
file to align with the proposed changes.build/tasks/format/format-md.mjs
file to ensure compatibility with the improved tasking structure..github/workflows/lint-and-test.yml
file to work with the updated tasking structure.Checklist
nps
solution and the CI workflow.Related Issues
Pull Request Type
Additional Information
Fixes #387.
To checkout this PR branch, run the following command in your terminal: