Calling delete on the frame in OnNewFrame() causes null ptr dereference in msvc runtime. When and how to free frames?

[chipweinberger]

How and when do we release frames? Doing this causes null ptr dereference =(
My listener looks like this:

bool PipedListener::onNewFrame(Frame::Type typ, Frame *f){

HANDLE pipe;
DWORD byte_width = f->width * f->height * f->bytes_per_pixel;

switch (typ){
case Frame::Type::Color:
    pipe = color_pipe;
    break;
case Frame::Type::Depth:
    pipe = depth_pipe;
    break;
default:
    return true;
}


DWORD bytes_written;
WriteFile(
    pipe, //hFile,
    f->data,//lpBuffer,
    byte_width,
    &bytes_written, //lpNumberOfBytesWritten,
    NULL //lpOverlapped
    );

//delete f;

}

[christiankerl]

You should return true if you take ownership of the frame e.g. call delete on it. Otherwise, the caller will delete or reuse the frame... So your default case should probably return false and at the end of your method return true

[chipweinberger]

Oh, thank you!! thank you!! Is documented anywhere? I feel stupid for not knowing this.

[floe]

Not really documented, we should probably at least add a comment in the header file.

[chipweinberger]

This still needs to be added to the header file btw.

[floe]

Thanks for the heads-up, added: 4a2dfd9