Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonPatchParser.h tries to include project header file #1086

Closed
daveol opened this issue May 31, 2016 · 2 comments
Closed

JsonPatchParser.h tries to include project header file #1086

daveol opened this issue May 31, 2016 · 2 comments
Assignees
@peternewman
Labels
API-C++ bug Difficulty-Easy Language-C++ OpSys-All
Milestone
0.10.3

Comments

@daveol
Copy link
Contributor

daveol commented May 31, 2016

The file include/ola/web/JsonPatchParser.h tries to include the project header file (that doesn't get installed) common/web/OptionalItem.h this fails because the file doesn't get installed by auto-tools/make
@peternewman peternewman changed the title JsonPatchParser.h tries tto include project header file JsonPatchParser.h tries to include project header file May 31, 2016
@peternewman peternewman added this to the 0.10.3 milestone May 31, 2016
@peternewman
Copy link
Member

Fix proposal, move the OptionalItem.h file to include/ola/web (leaving a placeholder version in the old location for backwards compatibility), which should solve the issue.

Alternatively rewrite JsonPatchParser to use auto_ptr or something and NULLs to track if the items have been provided or not.

@nomis52
Copy link
Member

nomis52 commented Jun 1, 2016

Move OptionalItem.h to include.

You don't need to leave the original in place common/ is only used internally.

@peternewman peternewman self-assigned this Jun 1, 2016
peternewman added a commit that referenced this issue Jun 3, 2016
@peternewman
Merge pull request #1089 from peternewman/0.10-json-patch-header
08ae147 
Move OptionalItem header to includes. Closes #1086
@nomis52 nomis52 closed this as completed in a5723c7 Jun 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peternewman peternewman

Labels
API-C++ bug Difficulty-Easy Language-C++ OpSys-All
Projects
None yet
Milestone
0.10.3
Development

No branches or pull requests
3 participants
@daveol @nomis52 @peternewman