Adding initial support for the img Stage Line DMX-1USB device #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… currently untested, but does compile. Hopefully closes OpenLightingProject#398
| @@ -198,6 +199,10 @@ void UsbDmxPlugin::FindDevices() { | |||
| device_descriptor.idProduct == 0xfa63) { | |||
| OLA_INFO << "Found a EUROLITE device"; | |||
| device = new EuroliteProDevice(this, usb_device); | |||
| } else if (device_descriptor.idVendor == 0x04d8 && | |||
| device_descriptor.idProduct == 0xff86) { | |||
There was a problem hiding this comment.
Done, and for the lines I copied it from.
|
Looks good, let's see if it works! |
peternewman
changed the title
…nto trivial-fixes
…nto trivial-fixes
…nto trivial-fixes
Merge branch 'trivial-fixes' of https://github.com/peternewman/ola into trivial-fixes
…nto trivial-fixes
…nto trivial-fixes
…nto trivial-fixes
…nto trivial-fixes
…nto trivial-fixes
…nto trivial-fixes
…nto trivial-fixes
…nto trivial-fixes
…nto trivial-fixes
peternewman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently untested, but does compile. Hopefully closes #398