Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handled the case where the coupon no longer exists #1278

Merged
merged 1 commit into from
Dec 12, 2020
Merged

Handled the case where the coupon no longer exists #1278

merged 1 commit into from
Dec 12, 2020

Conversation

boesbo
Copy link
Contributor

@boesbo boesbo commented Oct 22, 2020 •
edited
Loading

Related Pull Requests

#1117
#1111
#1031

Description (*)

If you cancel an order where there is a coupon that no longer exists, an SQL error is generated.

Manual testing scenarios (*)

  1. Create a coupon promotion
  2. Place it in an order
  3. Cancel the promotion
  4. Cancel the order

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added the Component: SalesRule Relates to Mage_SalesRule label Oct 22, 2020
@kkrieger85 kkrieger85 added the hacktoberfest easy to solve issues for https://hacktoberfest.digitalocean.com/ participant (and everyone else) label Oct 22, 2020
@boesbo
Copy link
Contributor Author

boesbo commented Nov 4, 2020

@drwilliams @mattdavenport

@mattdavenport
Copy link
Contributor

LGTM. Good fix!

@Flyingmana Flyingmana merged commit 36cf3b1 into OpenMage:1.9.4.x Dec 12, 2020
@sreichel sreichel added the bug label Dec 27, 2020
@sreichel sreichel added this to the Release 19.4.9 / 20.0.5 milestone Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreichel sreichel sreichel approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

Assignees
No one assigned
Labels
bug Component: SalesRule Relates to Mage_SalesRule hacktoberfest easy to solve issues for https://hacktoberfest.digitalocean.com/ participant (and everyone else)
Projects
None yet
Milestone
Release 19.4.9 / 20.0.5
Development

Successfully merging this pull request may close these issues.
6 participants
@boesbo @mattdavenport @colinmollenhour @sreichel @Flyingmana @kkrieger85