Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove orphan js/jscolor #1436

Merged
merged 1 commit into from
Feb 21, 2021
Merged

Remove orphan js/jscolor #1436

merged 1 commit into from
Feb 21, 2021

Conversation

jouriy
Copy link
Contributor

@jouriy jouriy commented Jan 30, 2021 •
edited
Loading

remove orphan js/jscolor/* from XmlConnect package

Description (*)

As all occurrences of XmlConnect are removed, cleaning up js/jscolor/* files from XmlConnect package

Related Pull Requests

  1. Ref Remove latest occurrences of XmlConnect #1383

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added the JavaScript Relates to js/* label Jan 30, 2021
@sreichel sreichel merged commit e4c2c4c into OpenMage:1.9.4.x Feb 21, 2021
@sreichel sreichel added this to the Release 19.4.12 / 20.0.8 milestone Feb 21, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e4c2c4c. ± Comparison against base commit 705389d.

@addison74 addison74 mentioned this pull request May 15, 2021
Closed
@addison74
Copy link
Contributor

Please put the directory back as soon as possible.

It was not related to XmlConnect only. See my report here #1615 .

Flyingmana added a commit to Flyingmana/magento-lts that referenced this pull request May 15, 2021
@Flyingmana
Revert "ref OpenMage#1383, cleanup - remove orphan js/jscolor/* from …
21d67a5 
…XmlConnect package (OpenMage#1436)"

Fixes OpenMage#1615
This reverts commit e4c2c4c
@Flyingmana Flyingmana mentioned this pull request May 15, 2021
Merged
Flyingmana added a commit that referenced this pull request May 17, 2021
@Flyingmana
Revert "ref #1383, cleanup - remove orphan js/jscolor/* from XmlConne…
9b04ad2 
…ct package (#1436)" (#1616)

Fixes #1615
This reverts commit e4c2c4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luigifab luigifab luigifab approved these changes

@sreichel sreichel sreichel approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

Assignees
No one assigned
Labels
Cleanup JavaScript Relates to js/*
Projects
None yet
Milestone
Release 19.4.12 / 20.0.8
Development

Successfully merging this pull request may close these issues.
5 participants
@jouriy @addison74 @colinmollenhour @sreichel @luigifab