-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option reindexallrequired #184
Conversation
Add option reindexallrequired as described here: http://magento.stackexchange.com/questions/3028/permanent-solution-for-the-common-indexing-issue
I think the condition on line 166 should also check that
Without this, indexers would be skipped even if they require a partial update There are also still cases where an indexer will run even if it is not required - for example if the price indexer requires a re-index then it will also run the stock indexer as it is a dependency. A simple/ugly workaround might be to add this loop at line 164 (untested): if ($this->getArg('reindexallrequired')) {
foreach ($processes as $process) {
if ($process->getStatus() == Mage_Index_Model_Process::STATUS_PENDING && count($process->getUnprocessedEventsCollection()) === 0) {
$process->setData('runed_reindexall', true);
}
}
} |
I think the main issue is to allow for a "re-run all" and if some exotic cases are missed this is OK.
|
testing the extra condition |
…r.php The new option only rebuilds indices that actually require a rebuild. http://magento.stackexchange.com/questions/3028/permanent-solution-for-the-common-indexing-issue
…r.php The new option only rebuilds indices that actually require a rebuild. http://magento.stackexchange.com/questions/3028/permanent-solution-for-the-common-indexing-issue
…r.php The new option only rebuilds indices that actually require a rebuild. http://magento.stackexchange.com/questions/3028/permanent-solution-for-the-common-indexing-issue
…r.php The new option only rebuilds indices that actually require a rebuild. http://magento.stackexchange.com/questions/3028/permanent-solution-for-the-common-indexing-issue
…r.php The new option only rebuilds indices that actually require a rebuild. http://magento.stackexchange.com/questions/3028/permanent-solution-for-the-common-indexing-issue
…r.php The new option only rebuilds indices that actually require a rebuild. http://magento.stackexchange.com/questions/3028/permanent-solution-for-the-common-indexing-issue
…r.php The new option only rebuilds indices that actually require a rebuild. http://magento.stackexchange.com/questions/3028/permanent-solution-for-the-common-indexing-issue
…r.php The new option only rebuilds indices that actually require a rebuild. http://magento.stackexchange.com/questions/3028/permanent-solution-for-the-common-indexing-issue
Add option reindexallrequired
as described here: http://magento.stackexchange.com/questions/3028/permanent-solution-for-the-common-indexing-issue