PHP 8.1 Fix cookie deletion behavior #1984
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
As described in the corresponding issue internal function
setcookie
only excepts string as value parameter and PHP 8.1 emits decription error (if not ignored by OpenMage) in case null is passed.While the prior way of using null still works (but with deprecation error) the_ correct way to delete the cookie is using an empty string as value. PHP internally changes the value to
deleted
which is sent in the response header. It's not necessary to pass anything else like a period that lies in the past (using negative value when calling set method of cookie model).Fixed Issues (if relevant)
Manual testing scenarios (*)
adminhtml=deleted
Contribution checklist (*)