Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated method _setAttribteValue() #419

Merged
merged 1 commit into from
Jan 25, 2018
Merged

Removed deprecated method _setAttribteValue() #419

merged 1 commit into from
Jan 25, 2018

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jan 8, 2018

deprecated after 1.5.1.0 - mistake in method name

... and mistake in fix :) Better remove then fix it?

@LeeSaferite
Copy link
Contributor

Magento really needs a documented deprecate then remove procedure.

@sreichel sreichel merged commit e2491cf into OpenMage:1.9.3.x Jan 25, 2018
@sreichel sreichel deleted the patch/dead-code-1 branch January 25, 2018 19:53
@Flyingmana
Copy link
Contributor

please add at least the PR number to the commit message when merging in this way

@sreichel
Copy link
Contributor Author

sreichel commented Feb 6, 2018

OK.

edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Feb 9, 2018
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Feb 28, 2018
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Mar 20, 2018
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Jul 17, 2018
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Sep 19, 2018
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Feb 14, 2019
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Apr 1, 2019
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 22, 2019
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Oct 25, 2019
@sreichel sreichel added the Component: Eav Relates to Mage_Eav label Jun 6, 2020
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants