-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add Infrastructure for SHGEMV #5485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This adds all the relevant bits and pieces to add a `shgemv` path as well as a future `hgemm`/`hgemv` path in a similar model to `sb` and `b` interfaces. I've also fixed a few bits and pieces around `shgemm` which didn't build in a few situations.
Thanks (pity about the duplicate work though) |
Yeah, sorry about that, I was thinking about something else and got a bit carried away seeing what was missing here 🙀 |
@martin-frbg I will leave |
Getting these compiler warnings....
|
Should probably be done like this https://stackoverflow.com/questions/42074035/how-to-deal-with-clangs-3-9-wexpansion-to-defined-warning
|
I see a couple of places in test/Makefile where BUILD_BFLOAT16 has been added but I don't see the same for BUILD_HFLOAT16. It looks like we have support for SBGEMM but not SHGEMM? |
This adds all the relevant bits and pieces to add a
shgemv
path as well as a futurehgemm
/hgemv
path in a similar model tosb
andb
interfaces.I've also fixed a few bits and pieces around
shgemm
which didn't build in a few situations.