Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit test_rnn #3092

Merged
merged 6 commits into from
Feb 26, 2020
Merged

Commit test_rnn #3092

merged 6 commits into from
Feb 26, 2020

Conversation

jimboH
Copy link
Contributor

@jimboH jimboH commented Feb 24, 2020

@karlhigley karlhigley requested a review from iamtrask February 24, 2020 16:09
@karlhigley karlhigley added the Type: Testing 🧪 Add testing or improving existing testing of a file, feature, or codebase label Feb 24, 2020
@iamtrask
Copy link
Member

Out of curiosity - I notice your error bounds are 1e-6. Part of me wishes that we could gte exactly the same (but this is out of scope for a project focused on extending our test coverage). How far off are we?

Copy link
Member

@iamtrask iamtrask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done!

@iamtrask iamtrask merged commit 4e5ee37 into OpenMined:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Testing 🧪 Add testing or improving existing testing of a file, feature, or codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants