Skip to content

fix ticket #6084 #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2020
Merged

fix ticket #6084 #127

merged 1 commit into from
Oct 30, 2020

Conversation

adrpo
Copy link
Member

@adrpo adrpo commented Oct 30, 2020

No description provided.

@adrpo adrpo requested a review from arun3688 October 30, 2020 16:50
@adrpo adrpo requested a review from sjoelund October 30, 2020 16:57
@adrpo
Copy link
Member Author

adrpo commented Oct 30, 2020

Thanks @arun3688. I have no idea if the code will work fine, can you send more arguments like that to self.requestApi?

@arun3688
Copy link
Collaborator

Thanks @arun3688. I have no idea if the code will work fine, can you send more arguments like that to self.requestApi?

Hi adrian that is a good question, I think we can use the sendExpression rather than the request API, I have changed most of the API to use sendExpression(),

@adrpo
Copy link
Member Author

adrpo commented Oct 30, 2020

I have looked more at the code, i think i can fix it. Let's see.

@adrpo adrpo merged commit dfd59b4 into master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants